Fix: make Docker Hub README sync non-fatal and run it after the version report - #7
Merged
Merged
Conversation
…on report In the v1.7.0 sf-docker-images release the description PATCH returned 403 Forbidden (push-scoped tokens cannot update repo descriptions — Docker Hub requires Read/Write/Delete scope or the account password). The failing step sat before the version-report steps, so all three push jobs failed after a successful push+sign and the caller's release job was skipped. The sync step now runs last with continue-on-error: true — cosmetic sync issues can no longer block the release path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During the sf-docker-images v1.7.0 release, all three push jobs failed at Sync README to Docker Hub — the description PATCH returned 403 Forbidden (Docker Hub requires a token with Read/Write/Delete scope, or the account password, for description updates; the push-scoped token works for
docker pushbut not for this endpoint). Because the step sat before the version-report steps, the report artifacts were skipped and the caller'sreleasejob never ran — even though the images were pushed and cosign-signed successfully.Changes:
continue-on-error: trueon the README-sync step — a cosmetic sync can never fail the release path againVerification
cosign verify×3 passes), GitHub Release created with the version tables generated from the published imagesNote: fixing the sync itself needs a new Docker Hub token with Read/Write/Delete scope in
DOCKERHUB_TOKEN— owner action.🤖 Generated with Claude Code