Update position on scroll (when appendToBody=true) #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from base.
Update dropdown position on scroll of parents elements when appendToBody=true - otherwise it gets separated from directive element on scroll.
Add .parents() to jqLite if jQuery is not present to make sure that repositioning works both with and without jQuery.
Gillardo
added a commit
that referenced
this pull request
May 21, 2015
Update position on scroll (when appendToBody=true)
Gillardo
added a commit
that referenced
this pull request
May 27, 2015
Issue #20 pull request causing error with $document.width() which is undefined, unless you have jquery. Removed this and applied left positioning
Owner
|
I have removed your scroll code as i was getting errors when implementing it on the demo. $document.width() is undefined, which i guess is because you are using jquery? |
Contributor
Author
|
Yes, I'm using jQuery. I'll check it without jquery, hopefully on this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dropdown position on scroll of parents elements when
appendToBody=true - otherwise it gets moved away from binding element if it's moved on scroll.