Skip to content

Conversation

@kevinbackhouse
Copy link
Collaborator

Models that are no longer supported, like claude-3.5-sonnet, are causing the smoke test to fail. This PR removes all hard-coded model names from the examples.

Copilot AI review requested due to automatic review settings December 2, 2025 11:06
Copilot finished reviewing on behalf of kevinbackhouse December 2, 2025 11:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes hard-coded model names from example taskflow files to prevent smoke test failures caused by deprecated models like claude-3.5-sonnet and gpt-4.1. The changes take two approaches: most files simply remove the model specification (allowing fallback to defaults), while example_reusable_taskflows.yaml demonstrates the recommended pattern by using model aliases (gpt_latest) with a model configuration reference.

  • Removes hard-coded model specifications from 5 example taskflow files
  • Updates example_reusable_taskflows.yaml to use model aliases (gpt_latest) with proper model configuration
  • Allows examples to use default or aliased models instead of potentially deprecated hard-coded values

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
examples/taskflows/single_step_taskflow.yaml Removed hard-coded gpt-4.1 model specification
examples/taskflows/example_triage_taskflow.yaml Removed hard-coded gpt-4.1 model specification
examples/taskflows/example_reusable_taskflows.yaml Changed from hard-coded gpt-4o to model alias gpt_latest and added model_config reference
examples/taskflows/example.yaml Removed two instances of hard-coded gpt-4.1 model specifications
examples/taskflows/echo.yaml Removed deprecated claude-3.5-sonnet model specification

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kevinbackhouse kevinbackhouse marked this pull request as ready for review December 2, 2025 11:25
Copilot AI review requested due to automatic review settings December 2, 2025 11:25
Copilot finished reviewing on behalf of kevinbackhouse December 2, 2025 11:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 8 to 9
taskflow:
- task:
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model reference was removed, but this file is being reused in example_reusable_taskflows.yaml which now references model_config: examples.model_configs.model_config and overrides with model: gpt_latest. However, single_step_taskflow.yaml itself doesn't have the model_config import. Consider adding model_config: examples.model_configs.model_config to this file for consistency and clarity, especially if it's meant to be reusable.

See below for a potential fix:

  filetype: taskflow
  model_config: examples.model_configs.model_config

Copilot uses AI. Check for mistakes.
@kevinbackhouse
Copy link
Collaborator Author

smoke test

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

⚠️ Cannot proceed with deployment

  • reviewDecision: APPROVED
  • commitStatus: PENDING

CI checks must be passing in order to continue

@kevinbackhouse
Copy link
Collaborator Author

smoke test

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Deployment Triggered 🚀

kevinbackhouse, started a branch deployment to smoketest (branch: 0315a96c918bc4bdcc7ccbd8acd0a1c94024f941)

You can watch the progress here 🔗

Details
{
  "type": "branch",
  "environment": {
    "name": "smoketest",
    "url": null
  },
  "deployment": {
    "timestamp": "2025-12-02T12:05:29.439Z",
    "logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19857970802"
  },
  "git": {
    "branch": "0315a96c918bc4bdcc7ccbd8acd0a1c94024f941",
    "commit": "0315a96c918bc4bdcc7ccbd8acd0a1c94024f941",
    "verified": true,
    "committer": "web-flow",
    "html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/commit/0315a96c918bc4bdcc7ccbd8acd0a1c94024f941"
  },
  "context": {
    "actor": "kevinbackhouse",
    "noop": false,
    "fork": true,
    "comment": {
      "created_at": "2025-12-02T12:05:12Z",
      "updated_at": "2025-12-02T12:05:12Z",
      "body": "smoke test",
      "html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/pull/103#issuecomment-3601698896"
    }
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Deployment Results ✅

kevinbackhouse successfully deployed branch 0315a96c918bc4bdcc7ccbd8acd0a1c94024f941 to smoketest

Details
{
  "status": "success",
  "environment": {
    "name": "smoketest",
    "url": null
  },
  "deployment": {
    "id": 3405109246,
    "timestamp": "2025-12-02T12:09:02.553Z",
    "logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19857970802",
    "duration": 213
  },
  "git": {
    "branch": "0315a96c918bc4bdcc7ccbd8acd0a1c94024f941",
    "commit": "0315a96c918bc4bdcc7ccbd8acd0a1c94024f941",
    "verified": true
  },
  "context": {
    "actor": "kevinbackhouse",
    "noop": false,
    "fork": true
  },
  "reviews": {
    "count": 1,
    "decision": "APPROVED"
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

@kevinbackhouse kevinbackhouse merged commit 9359c8b into GitHubSecurityLab:main Dec 2, 2025
9 checks passed
@kevinbackhouse kevinbackhouse deleted the remove-hardcoded-models branch December 2, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants