-
Notifications
You must be signed in to change notification settings - Fork 6
Remove hard-coded models from examples #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hard-coded models from examples #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes hard-coded model names from example taskflow files to prevent smoke test failures caused by deprecated models like claude-3.5-sonnet and gpt-4.1. The changes take two approaches: most files simply remove the model specification (allowing fallback to defaults), while example_reusable_taskflows.yaml demonstrates the recommended pattern by using model aliases (gpt_latest) with a model configuration reference.
- Removes hard-coded model specifications from 5 example taskflow files
- Updates
example_reusable_taskflows.yamlto use model aliases (gpt_latest) with proper model configuration - Allows examples to use default or aliased models instead of potentially deprecated hard-coded values
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/taskflows/single_step_taskflow.yaml | Removed hard-coded gpt-4.1 model specification |
| examples/taskflows/example_triage_taskflow.yaml | Removed hard-coded gpt-4.1 model specification |
| examples/taskflows/example_reusable_taskflows.yaml | Changed from hard-coded gpt-4o to model alias gpt_latest and added model_config reference |
| examples/taskflows/example.yaml | Removed two instances of hard-coded gpt-4.1 model specifications |
| examples/taskflows/echo.yaml | Removed deprecated claude-3.5-sonnet model specification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| taskflow: | ||
| - task: |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model reference was removed, but this file is being reused in example_reusable_taskflows.yaml which now references model_config: examples.model_configs.model_config and overrides with model: gpt_latest. However, single_step_taskflow.yaml itself doesn't have the model_config import. Consider adding model_config: examples.model_configs.model_config to this file for consistency and clarity, especially if it's meant to be reusable.
See below for a potential fix:
filetype: taskflow
model_config: examples.model_configs.model_config
|
smoke test |
|
|
smoke test |
Deployment Triggered 🚀kevinbackhouse, started a branch deployment to smoketest (branch: You can watch the progress here 🔗 Details{
"type": "branch",
"environment": {
"name": "smoketest",
"url": null
},
"deployment": {
"timestamp": "2025-12-02T12:05:29.439Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19857970802"
},
"git": {
"branch": "0315a96c918bc4bdcc7ccbd8acd0a1c94024f941",
"commit": "0315a96c918bc4bdcc7ccbd8acd0a1c94024f941",
"verified": true,
"committer": "web-flow",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/commit/0315a96c918bc4bdcc7ccbd8acd0a1c94024f941"
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true,
"comment": {
"created_at": "2025-12-02T12:05:12Z",
"updated_at": "2025-12-02T12:05:12Z",
"body": "smoke test",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/pull/103#issuecomment-3601698896"
}
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Deployment Results ✅kevinbackhouse successfully deployed branch Details{
"status": "success",
"environment": {
"name": "smoketest",
"url": null
},
"deployment": {
"id": 3405109246,
"timestamp": "2025-12-02T12:09:02.553Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19857970802",
"duration": 213
},
"git": {
"branch": "0315a96c918bc4bdcc7ccbd8acd0a1c94024f941",
"commit": "0315a96c918bc4bdcc7ccbd8acd0a1c94024f941",
"verified": true
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true
},
"reviews": {
"count": 1,
"decision": "APPROVED"
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Models that are no longer supported, like
claude-3.5-sonnet, are causing the smoke test to fail. This PR removes all hard-coded model names from the examples.