-
Notifications
You must be signed in to change notification settings - Fork 6
Split into two jobs #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split into two jobs #107
Conversation
…t on branch-deploy step succeeding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the smoke test workflow by splitting a single Linux job into two separate jobs (permission-check and run-tests) to improve conditional logic handling. The separation allows the branch-deploy permission check to output its result, which is then used to conditionally execute the test steps.
Key Changes:
- Extracted permission checking logic into a dedicated
permission-checkjob that outputs the deployment continuation status - Created a new
run-testsjob that depends onpermission-checkand only executes when deployment is allowed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@JarLob: do you think this will work? |
|
smoke test |
|
|
smoke test |
Deployment Triggered 🚀kevinbackhouse, started a branch deployment to smoketest (branch: You can watch the progress here 🔗 Details{
"type": "branch",
"environment": {
"name": "smoketest",
"url": null
},
"deployment": {
"timestamp": "2025-12-03T18:22:38.049Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19904391620"
},
"git": {
"branch": "02bc1d71ba380e8851841307615e542329e80f70",
"commit": "02bc1d71ba380e8851841307615e542329e80f70",
"verified": true,
"committer": "web-flow",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/commit/02bc1d71ba380e8851841307615e542329e80f70"
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true,
"comment": {
"created_at": "2025-12-03T18:22:20Z",
"updated_at": "2025-12-03T18:22:20Z",
"body": "smoke test",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/pull/107#issuecomment-3608210294"
}
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Deployment Results ✅kevinbackhouse successfully deployed branch Details{
"status": "success",
"environment": {
"name": "smoketest",
"url": null
},
"deployment": {
"id": 3414532042,
"timestamp": "2025-12-03T18:26:08.638Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19904391620",
"duration": 211
},
"git": {
"branch": "02bc1d71ba380e8851841307615e542329e80f70",
"commit": "02bc1d71ba380e8851841307615e542329e80f70",
"verified": true
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true
},
"reviews": {
"count": 1,
"decision": "APPROVED"
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Hopefully this will make the conditional logic work correctly.