Skip to content

Conversation

@kevinbackhouse
Copy link
Collaborator

Hopefully this will make the conditional logic work correctly.

Copilot AI review requested due to automatic review settings December 3, 2025 16:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the smoke test workflow by splitting a single Linux job into two separate jobs (permission-check and run-tests) to improve conditional logic handling. The separation allows the branch-deploy permission check to output its result, which is then used to conditionally execute the test steps.

Key Changes:

  • Extracted permission checking logic into a dedicated permission-check job that outputs the deployment continuation status
  • Created a new run-tests job that depends on permission-check and only executes when deployment is allowed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kevinbackhouse kevinbackhouse marked this pull request as ready for review December 3, 2025 16:23
Copilot AI review requested due to automatic review settings December 3, 2025 16:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 3, 2025 17:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kevinbackhouse
Copy link
Collaborator Author

@JarLob: do you think this will work?

@kevinbackhouse
Copy link
Collaborator Author

smoke test

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

⚠️ Cannot proceed with deployment

  • reviewDecision: APPROVED
  • commitStatus: PENDING

CI checks must be passing in order to continue

@kevinbackhouse
Copy link
Collaborator Author

smoke test

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Deployment Triggered 🚀

kevinbackhouse, started a branch deployment to smoketest (branch: 02bc1d71ba380e8851841307615e542329e80f70)

You can watch the progress here 🔗

Details
{
  "type": "branch",
  "environment": {
    "name": "smoketest",
    "url": null
  },
  "deployment": {
    "timestamp": "2025-12-03T18:22:38.049Z",
    "logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19904391620"
  },
  "git": {
    "branch": "02bc1d71ba380e8851841307615e542329e80f70",
    "commit": "02bc1d71ba380e8851841307615e542329e80f70",
    "verified": true,
    "committer": "web-flow",
    "html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/commit/02bc1d71ba380e8851841307615e542329e80f70"
  },
  "context": {
    "actor": "kevinbackhouse",
    "noop": false,
    "fork": true,
    "comment": {
      "created_at": "2025-12-03T18:22:20Z",
      "updated_at": "2025-12-03T18:22:20Z",
      "body": "smoke test",
      "html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/pull/107#issuecomment-3608210294"
    }
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Deployment Results ✅

kevinbackhouse successfully deployed branch 02bc1d71ba380e8851841307615e542329e80f70 to smoketest

Details
{
  "status": "success",
  "environment": {
    "name": "smoketest",
    "url": null
  },
  "deployment": {
    "id": 3414532042,
    "timestamp": "2025-12-03T18:26:08.638Z",
    "logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19904391620",
    "duration": 211
  },
  "git": {
    "branch": "02bc1d71ba380e8851841307615e542329e80f70",
    "commit": "02bc1d71ba380e8851841307615e542329e80f70",
    "verified": true
  },
  "context": {
    "actor": "kevinbackhouse",
    "noop": false,
    "fork": true
  },
  "reviews": {
    "count": 1,
    "decision": "APPROVED"
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

@kevinbackhouse kevinbackhouse merged commit 10752b4 into GitHubSecurityLab:main Dec 4, 2025
9 checks passed
@kevinbackhouse kevinbackhouse deleted the smoketest-stop-on-error branch December 4, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants