feat: support regex tag exclusions - #5147
Conversation
a69984b to
e0c2108
Compare
|
Hi @HHobeck, could you please take a look at this PR when you have a chance? Thank you! |
e0c2108 to
5b7f820
Compare
5b7f820 to
854943a
Compare
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 ⛓️ Depends-On RequirementsRequirement based on the presence of
|
854943a to
192ef29
Compare
192ef29 to
f71b9ec
Compare
f71b9ec to
73bae1b
Compare
|
Tick the box to add this pull request to the merge queue (same as
|
|
I need some time for the review. Anyway, what I was thinking about: Could we make case-insensitivity optional? Users who need it can easily add the modifier inline themselves, for example: |
|
Thanks for raising this. GitVersion currently compiles configuration-supplied regexes through the shared I’d therefore prefer to keep Users who need case-sensitive matching can disable case-insensitive matching inline with ignore:
tags:
- '(?-i)^experimental-'\n```\n\nThis matches `experimental-...` but not `Experimental-...`. |
Hmm okay. Can you document it? Fair enough if we want to have the behavior to be case insensitive. But why we have for example this in our configuration? tag-prefix: "[vV]?"
version-in-branch-pattern: "(?<version>[vV]?\\d+(\\.\\d+)?(\\.\\d+)?).*" |
588e9ed to
a1c81bc
Compare
|
|
Hi @HHobeck, when you have a chance, could you please take another look at the updated PR? Your review feedback has been addressed. Thank you! |
|
Thank you @arturcic for your contribution! |



Description
Adds
ignore.tags, a sequence of regular expressions for excluding tags from version-source discovery.refs/tags/.Related issue
Part of #5130.
Stack
Depends-On: #5151
Validation
GitVersion.Configuration.Tests: 107 passed.GitVersion.Core.Testswith LibGit2Sharp: 7 passed.GitVersion.Core.Testswith managed Git: 7 passed.dotnet format src/GitVersion.slnx --no-restorecompleted successfully.schemas/7.0/GitVersion.configuration.json.Checklist