Skip to content

Fix #65: Plugins Architecture#123

Merged
AaronO merged 18 commits into
masterfrom
feature/plugins
Apr 21, 2014
Merged

Fix #65: Plugins Architecture#123
AaronO merged 18 commits into
masterfrom
feature/plugins

Conversation

@SamyPesse
Copy link
Copy Markdown
Member

Fix #65

@SamyPesse
Copy link
Copy Markdown
Member Author

@AaronO it's ready to be merged 😄

AaronO added a commit that referenced this pull request Apr 21, 2014
@AaronO AaronO merged commit 4c90fdb into master Apr 21, 2014
@AaronO AaronO deleted the feature/plugins branch April 21, 2014 21:26
@AaronO
Copy link
Copy Markdown

AaronO commented Apr 21, 2014

Merged

@bebraw
Copy link
Copy Markdown

bebraw commented Apr 22, 2014

Great!

A couple of notes:

  • You should mention the sample plugin at README so it's more obvious to people
  • Would it be possible to add a hook for marked? That would come in handy if some people want custom syntax.

@AaronO
Copy link
Copy Markdown

AaronO commented Apr 22, 2014

@bebraw We'll document the sample plugin a bit more before the 0.3.0 release tomorrow.

To be honest, I'm against major modifications to the syntax when it can be avoided. Using a new syntax makes it harder for other people to reuse, understand etc ...

You've been mentioning adding syntax for doing your screenshot phase. What I would do if I were you would be the following.

Write a small quick n dirty parser either leveraging marked or regexes, that finds the screenshots to be made, write a grunt/gulp/whatever task using that and phantomjs to take care of the screenshots.

Have a Gruntfile/Gulpfile with two tasks, first get screenshots, second build book.

I think by wanting to bring the screenshot build process into a gitbook plugin you are coupling your system, making future upgrade potentially dangerous etc ...

And to be honest, I think it's best to be decoupled when possible. I don't really see the advantage of being coupled in this scenario.

Sorry if I'm not getting your pain point ;)

@bebraw
Copy link
Copy Markdown

bebraw commented Apr 22, 2014

No probs! It's definitely possible to deal with this scenario in two passes like you describe. I'll give it a go. :)

@SamyPesse SamyPesse restored the feature/plugins branch April 22, 2014 09:51
@SamyPesse SamyPesse deleted the feature/plugins branch April 22, 2014 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants