fix(tui): unblock main — picker_test for switchProviderModel 4-value return#589
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA test assertion in picker_test.go was updated to accommodate an additional return value from the switchProviderModel function call, changing a single ignored placeholder to two ignored placeholders. ChangesTest Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Zero automated PR reviewVerdict: No blockers found Blockers
Validation
ScopeHead: This deterministic review checks validation status and basic diff hygiene. A human reviewer still owns product judgment and design quality. |
|
@kevincodex1 merge this this is the issue of getting ci fails |
…itlawb#589) Gitlawb#568 added a bool return to switchProviderModel (model, string, bool, tea.Cmd) and updated every call site except picker_test.go:771, which still assigned three values. That broke the internal/tui test build and turned Smoke red on main. Add the missing receiver here.
fix(tui): update picker_test for switchProviderModel 4-value return (Gitlawb#589) tea.Cmd) and updated every call site except picker_test.go:771, which still assigned three values. That broke the internal/tui test build and turned Smoke red on main. Add the missing receiver here. fix: make HashTree self-delimiting and fix skills format-output test - fscopy: tag dir/file type and byte size in HashTree so the stream is self-delimiting and two different trees cannot hash identically. - skills: match the %q-quoted skills root in the format-output test so it no longer fails on Windows path escaping. fix: make HashTree self-delimiting and fix skills format-output test │ ✓ exec_command │ - fscopy: tag dir/file type and byte size in HashTree so the stream is │ self-delimiting and two different trees cannot hash identically. │ - skills: match the %q-quoted skills root in the format-output test so it │ no longer fails on Windows path escaping.
#568 added a bool return to switchProviderModel (model, string, bool, tea.Cmd) and updated every call site except picker_test.go:771, which still assigned three values. That broke the internal/tui test build and turned Smoke red on main. Add the missing receiver here.
main's Smoke is red. #568 added a fourth return value (
bool) toswitchProviderModelininternal/tui/command_center.goand updated every call site except one —internal/tui/picker_test.go:771still assigns three values:That fails the
internal/tuitest build on all three Smoke jobs, so every open PR is blocked behind branch protection.One-line fix: add the missing receiver so the test matches the signature the other five call sites already use. No runtime change.
Merge unblocks CI on the rest of the queue.
Summary by CodeRabbit