fix: bump Go to 1.26.5 for crypto/tls fix (GO-2026-5856)#607
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe go.mod file's go directive was updated from version 1.26.4 to 1.26.5. No other changes, dependency entries, or exported/public entity declarations were modified. ChangesGo Version Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Zero automated PR reviewVerdict: No blockers found Blockers
Validation
ScopeHead: This deterministic review checks validation status and basic diff hygiene. A human reviewer still owns product judgment and design quality. |
gnanam1990
left a comment
There was a problem hiding this comment.
Review (post-merge audit)
Verdict: Looks correct. Agree this was the right minimal fix.
One-line bump of the go directive from 1.26.4 → 1.26.5 addresses GO-2026-5856 (crypto/tls ECH privacy issue) that was failing CI govulncheck. Workflows resolve the toolchain via go-version-file: go.mod, so changing the directive is the complete lever — no app code or go.sum change needed. CI including Security & code health went green on the tip that merged.
Notes (non-blocking)
- No linked parent issue /
issue-approved— acceptable for a direct CI/toolchain security point release, as noted in the PR checklist. - No remaining
1.26.4pins found in workflows; they all followgo.mod.
No correctness concerns. Shipping this unblocked other open PRs that were failing Security on 1.26.4.
Summary
Bumps the Go toolchain from 1.26.4 to 1.26.5 to fix GO-2026-5856, an Encrypted
Client Hello privacy leak in the standard library's
crypto/tlsthat wasfailing CI's govulncheck job. Our code reaches the vulnerable paths through
normal TLS usage — the MCP OAuth callback server, dictation downloads, and the
daemon protocol/remote client — so any TLS use tripped it.
Since every workflow resolves the toolchain via
go-version-file: go.mod,bumping the
godirective is the complete fix; no code changes needed.Verified:
go run golang.org/x/vuln/cmd/govulncheck@v1.3.0 ./...now reportsNo vulnerabilities found (this also clears the second, uncalled dependency
finding from the failing run).
Checklist
issue-approvedlabel. (No linked issue — direct fix for the currently failing govulncheck CI job.)go build ./...,go vet ./..., andgo test ./...pass locally.gofmtclean.-racewhere relevant). (N/A — toolchain version bump only, no code changed; full existing suite passes on 1.26.5.)Summary by CodeRabbit