feat(providers): refresh MiniMax model and endpoint coverage#665
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughMiniMax setup documentation now covers API keys, presets, regional custom profiles, and base URLs. MiniMax catalog metadata, provider routing, think-tag parsing, and MiniMax M3 vision fallback behavior are updated with corresponding tests. ChangesMiniMax support
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Vasanthdev2004
left a comment
There was a problem hiding this comment.
Reviewed #665 against the prior #611 concerns. This cleanly supersedes #611: it leaves the MiniMax base URLs at /anthropic (the provider descriptor file is untouched), so there's no /v1 doubling, and the new endpoint test asserts the resolved request URL for both regions and both compatible protocols — exactly the regression test that was asked for. Build, tests on the touched packages, vet, and gofmt are all clean, and the merge applies cleanly.
I also checked for the attribution pattern from the earlier preset PR: no partner/rebate/affiliate header, no recommended-tier elevation of MiniMax, and no hardcoded signing key or official-source trust anchor — the only new constant is a docs URL used as the model Source field. #611 is closed and should stay closed in favor of this one. The missing linked approved issue is the same gap that was waived on #611; I'm not blocking on it for a model refresh of an existing provider.
One minor note: the new minimax-m2 think-tag marker in the provider wiring also matches MiniMax-M2.1, which the catalog doesn't mark as a reasoning model — harmless in practice since stripping tags a model never emits is a no-op, but could be tightened to minimax-m2.7 later if M2.1 is definitively non-reasoning.
kevincodex1
left a comment
There was a problem hiding this comment.
looks great. thanks for contribution. please join discord
Supersedes #611 with a clean history based on the latest
mainbranch.Summary
MiniMax-M2.7to the global and China provider model catalogs.MiniMax-M3andMiniMax-M2.7.MiniMax-M3and inline thinking parsing for M2.x models on OpenAI-compatible profiles.Verification
go fmt ./...go test -p 1 ./...make build-allgo vet ./...make lintgo run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2 run --enable-only unused,ineffassign,staticcheck --new-from-rev=origin/main ./...go run golang.org/x/vuln/cmd/govulncheck@v1.3.0 ./...Summary by CodeRabbit
New Features
Documentation