feat(plugin) + fix(tool) + ci: plugin system, tool improvements, and GitHub CI#1
Merged
Merged
Conversation
Introduce a plugin module that enables out-of-process tool execution via gRPC. Includes protocol definitions (protobuf), server scaffolding, type mappings, and tests. Made-with: Cursor
- SchemaBuilder.Required() now deduplicates field names - Add PropertyWithDefault() for properties with default values - Migrate memory and extract tool definitions to DefineSchema builder, eliminating hand-written map[string]any for consistent style - Registry.Execute returns ToolResult only (no error), so tool-not-found is handled identically to tool execution failures Made-with: Cursor
Tests were asserting Chinese text but the implementation was changed to English. Update assertions to match current output. Made-with: Cursor
- ci.yml: runs on PRs with path-based filtering (sdk, sdkx, plugin, examples). Gate job "CI" aggregates results for branch protection. - post-merge.yml: lightweight build+vet on push to main. - Branch protection configured to require "CI" check before merge. Made-with: Cursor
voice-pipeline depends on portaudio which is unavailable in CI. Drop examples from CI jobs and fix formatting in plugin/serve_test.go. Made-with: Cursor
This was referenced May 12, 2026
lIang70
added a commit
that referenced
this pull request
May 14, 2026
Silent multi-minute ingest is the #1 driver of "is it stuck?" pages on the bm25-only path (no embedder = no network log line for 5183 docs × ~60ms tokenize/index). The lane phase already emitted milestone events but only the Feishu adapter saw them — operators running the binary directly or tailing nohup-style logs got nothing. Two changes: * ingest() now emits "ingest_start" once and "ingest_progress" at each opts.ProgressPct milestone (mirrors the runLane progress pattern). Default 10% steps means scifact's 5183-doc ingest emits ~10 lines, which is the right resolution to distinguish "BM25 indexing" from "stuck on a network call". * CLI Hook now mirrors a small allow-list of lifecycle events (start / ingest_* / lane_* / done / error) to stderr alongside forwarding them to the notifier. The allow-list keeps any future debug-y emits off the operator's screen. Verified end-to-end on a 3-doc / 2-query mini-dataset with `--notify-progress-pct 50`: stderr now prints 8 lifecycle lines in order; the existing TestRun_HookEvents lifecycle-sequence assertion was updated to expect "ingest_start" between "start" and "ingest_done". No behavioural change to the report payload — this is pure visibility. Co-authored-by: Cursor <cursoragent@cursor.com>
lIang70
added a commit
that referenced
this pull request
May 21, 2026
Harden lease-recycle recovery under scope lock, transient retry with RetryAt/Attempt persistence, and require Scope/RuntimeID for drain and stats so workers cannot claim or observe cross-tenant queue state. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Required(), and makeRegistry.ExecutereturnToolResultonly for consistent error semanticsCommits
feat(plugin): add gRPC-based plugin systemplugin/,go.workfix(tool): unify schema style and Execute error semanticssdk/tool/,sdk/memory/tools.go,sdkx/extract/tool.gofix(memory): align summary index tests with English header textsdk/memory/summary_index_test.goci: add GitHub Actions with path-filtered jobs.github/workflows/Test plan
go test ./sdk/... -count=1passesgo test ./sdkx/... -count=1passesgo test ./plugin/... -count=1passesCI) reports green on this PRMade with Cursor