Skip to content

fix(ci): create PR instead of direct push for sdkx dependency bumps#15

Merged
lIang70 merged 1 commit into
mainfrom
fix/auto-tag-protected-branch
Apr 16, 2026
Merged

fix(ci): create PR instead of direct push for sdkx dependency bumps#15
lIang70 merged 1 commit into
mainfrom
fix/auto-tag-protected-branch

Conversation

@lIang70

@lIang70 lIang70 commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix auto-tag workflow: the "Cascade sdk bump to sdkx" step was pushing directly to main, which is rejected by branch protection (requires CI status check). Changed to create a PR via gh pr create instead.
  • Fix "Tag sdkx" condition: the old if: env.TAGGED_SDK != '' || success() was always true. Now uses if: env.TAGGED_SDK == '' so it only runs for independent sdkx changes. When sdk is tagged, the bump PR merge re-triggers auto-tag to tag sdkx automatically.
  • Bump sdkx/go.mod: updates sdk dependency from v0.1.5 to v0.1.6 (the version that failed to propagate due to this bug).

Test plan

  • Verify workflow YAML syntax is valid
  • Merge and confirm next auto-tag run succeeds

Made with Cursor

The auto-tag workflow's "Cascade sdk bump to sdkx" step was pushing
directly to main, which fails due to branch protection requiring CI
status checks. Fix by creating a PR via gh cli instead.

Also fixes the "Tag sdkx" step condition (`success()` was always true)
to only run when sdk was NOT tagged (independent sdkx changes). When
sdk IS tagged, the bump PR merge will re-trigger auto-tag to tag sdkx.

Additionally bumps sdkx/go.mod to sdk v0.1.6 (the version that failed
to propagate due to this bug).

Made-with: Cursor
@lIang70
lIang70 merged commit 4a19181 into main Apr 16, 2026
9 checks passed
@lIang70
lIang70 deleted the fix/auto-tag-protected-branch branch April 16, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant