fix(memory): use ArchiveConfig.ArchivePrefix instead of hardcoded 'archive'#20
Merged
Conversation
…chive"
ArchiveConfig.ArchivePrefix is defined with a default value of "archive"
but never actually consumed by any code path. The archive.go internal
helpers archiveDir() and manifestPath() hardcoded the "archive"
subdirectory name.
This change passes cfg.ArchivePrefix into archiveDir(), manifestPath(),
intentPath(), writeIntent(), deleteIntent(), loadIntent(), replacing
the hardcoded "archive" string. The external prefix parameter (root
directory) remains unchanged, consistent with other stores.
Directory layout (unchanged by default):
{prefix}/{convID}/{ArchivePrefix}/manifest.json
{prefix}/{convID}/{ArchivePrefix}/messages_0_499.jsonl.gz
{prefix}/{convID}/{ArchivePrefix}/intent.json
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArchiveConfig.ArchivePrefixwhich was defined but never actually used"archive"subdirectory name inarchiveDir()andmanifestPath()withcfg.ArchivePrefixprefixparameter (root directory) remains unchangedChanges
archivePrefix(fromcfg.ArchivePrefix) intoarchiveDir(),manifestPath(),intentPath(),writeIntent(),deleteIntent(),loadIntent()LoadManifest/LoadArchivedMessagescallers now readt.deps.Config.Archive.ArchivePrefixDirectory layout (unchanged by default)
Default
ArchivePrefix = "archive"preserves backward compatibility.Test plan
🤖 Generated with Claude Code