fix(adapter): inject default variable resolver in graphRunnable.Execute#4
Merged
Merged
Conversation
graphRunnable.Execute did not inject a variable.NewResolver() like
Runner.Run does, causing ${board.xxx} references in node configs to
go unresolved when graphs are executed through the workflow adapter.
Made-with: Cursor
lIang70
added a commit
that referenced
this pull request
Apr 14, 2026
…nnable
Verifies that ${board.xxx} references in node configs are correctly
resolved when executed through the adapter path (covers the fix in #4).
Made-with: Cursor
2 tasks
2 tasks
lIang70
added a commit
that referenced
this pull request
May 21, 2026
Propagate queue Complete/Fail errors, prefer enqueue TurnsSnapshot over lossy canonical parse, and emit ForgetAll/ExpireRetired telemetry with AsyncJobsCancelled after trace is populated. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adapter.graphRunnable.Execute()did not inject a defaultvariable.NewResolver()likeexecutor.Runner.Run()does, causing${board.xxx}variable references in node configs to go unresolved when graphs are executed through the workflow adapter.execOptswithexecutor.WithResolver(variable.NewResolver())ingraphRunnable.Execute(), matching the behavior ofRunner.Run().ExtExecutorRunOpts.Test plan
go build ./graph/adapter/...compiles successfullygo test ./graph/adapter/...all tests pass${board.xxx}references resolves variables correctly when executed through the adapter path