hotfix(tests/quality/knowledge): restore missing go.mod / doc.go [skip-tag:sdk]#57
Merged
Merged
Conversation
…p-tag:sdk] PR #56 (consolidate test suites under tests/) was committed before the .gitignore whitelist was extended to cover tests/, so the three new (untracked) files in tests/quality/knowledge — go.mod, go.sum, doc.go — were silently elided by `git add -A`. The 'git mv'-tracked test sources made it through because already-tracked files bypass .gitignore, which masked the gap until this branch tried to run the suite end-to-end. This hotfix: - Adds `!tests/` / `!tests/**` to .gitignore so tests/ is on the same allowlist as bench/, examples/, sdk/, sdkx/, voice/, tools/. - Restores tests/quality/knowledge/go.mod (independent module pinning sdk v0.2.7 + sdkx v0.2.5, matching what PR #56's commit message described). - Restores tests/quality/knowledge/doc.go (package doc explaining why the suite lives outside sdk). - Restores tests/quality/knowledge/go.sum (generated by `go mod tidy` against the pinned versions; identical content guaranteed by `GOPROXY` for those tags). Verification: `make test` is green again across all modules, including tests/quality/knowledge in the GOWORK=off lane. [skip-tag:sdk] because nothing under sdk/ changes here. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #56 (consolidate test suites under
tests/) silently elided three new files intests/quality/knowledge/—go.mod,go.sum,doc.go— because.gitignoredid not yet havetests/on its allowlist when the commit was authored.git mv-tracked test sources made it through unaffected (already-tracked files bypass.gitignore), which masked the gap until I tried to run the suite end-to-end on the next branch and noticed the module was missing its descriptor entirely.make testonmainHEAD is currently broken attests/quality/knowledgebecause there is nogo.modfor the directory.Changes
.gitignore: extend the whitelist with!tests//!tests/**sotests/is on the same footing asbench//examples//sdk//sdkx//voice//tools/.tests/quality/knowledge/go.mod: independent module pinningsdk v0.2.7+sdkx v0.2.5(the versions PR refactor: consolidate test suites under tests/ [skip-tag:sdk] #56's commit message claimed were used).tests/quality/knowledge/go.sum: generated byGOWORK=off go mod tidyagainst the pinned tags.tests/quality/knowledge/doc.go: package-level doc explaining why the suite lives outsidesdk(independent release cadence, decoupled bumps).[skip-tag:sdk]rationaleNothing under
sdk/changes — this is purely undertests/quality/knowledge/plus a top-level.gitignoreallowlist tweak. No need for the auto-tag workflow to bumpsdk.Test plan
cd tests/quality/knowledge && GOWORK=off go mod tidy— cleancd tests/quality/knowledge && GOWORK=off go vet ./...— cleancd tests/quality/knowledge && GOWORK=off go test ./...— passes (BM25 lane, no creds)make testfrom repo root — green across all modules including the previously-brokentests/quality/knowledgeMade with Cursor