docs: restore RRF mention in recall highlights#68
Merged
Conversation
Re-verifying against sdk/retrieval/pipeline/factory.go shows recall
DOES use Reciprocal Rank Fusion — RRFFusion{K: 60} is the canonical
fusion stage in both Default() and LTM(), with EntityBoost as a
post-fusion re-rank signal, not a replacement.
Earlier commit on this branch overcorrected and removed the RRF
claim. Restored and made the description more precise: three-lane
retrieval (BM25 + vector + entity) → RRF → entity boost / supersede
decay / time decay → limit.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up correction to PR #67. After deeper code review, the previous "RRF was an exaggeration" rewrite was itself wrong.
What I missed
`sdk/recall.New()` constructs its retrieval pipeline via `sdk/retrieval/pipeline.LTM()`, which canonically uses:
```go
// sdk/retrieval/pipeline/factory.go
MultiRetrieve{ BM25, Vector, Entity },
RRFFusion{K: 60}, // ← this IS Reciprocal Rank Fusion
EntityBoost{Boost: 0.4},
ScoreThreshold{...},
SupersededDecay{...},
TimeDecay{...},
Limit{...},
```
`RRFFusion` (defined in `sdk/retrieval/pipeline/stages_fusion.go`) is the standard `1 / (k + rank)` fusion. EntityBoost is a post-fusion re-rank signal, not a replacement for RRF.
Fix
Restored the RRF mention and made it more precise: three-lane retrieval (BM25 + vector + entity) → RRF → entity boost / supersede decay / time decay → limit.
Test plan
Made with Cursor