Clarified the PSA_ERROR_BAD_STATE conditions for multi-part operations - #381
Open
athoelke wants to merge 1 commit into
Open
Clarified the PSA_ERROR_BAD_STATE conditions for multi-part operations#381athoelke wants to merge 1 commit into
PSA_ERROR_BAD_STATE conditions for multi-part operations#381athoelke wants to merge 1 commit into
Conversation
athoelke
added
clarification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the discussion of #375, which introduces additional operation objects with complex implied state-models, it was noted that the phrasing of the valid/invalid operation states which can give rise to a
PSA_ERROR_BAD_STATEerror had become complicated, and in places, confusing.A change in the pattern of these condition clauses is introduced in #375 for the interruptible operations. This PR applies the same pattern to the existing multi-part hash, XOF, MAC, cipher, AEAD, asymmetric signature, key-derivation, and PAKE operations.
Where previously these clauses had been phrased:
these are now changed to a set of clauses, any of which are sufficient to result in a
PSA_ERROR_BAD_STATEresponse. The result is a pattern that closely matches the style used for other error return values where more than one condition can result in the error.