Skip to content

fix Android 7/7.1 crashes, rename Bashrc templates label, update docs and changelog - #6

Merged
GlobalTechInfo merged 1 commit into
mainfrom
android7-fixes
Aug 2, 2026
Merged

fix Android 7/7.1 crashes, rename Bashrc templates label, update docs and changelog#6
GlobalTechInfo merged 1 commit into
mainfrom
android7-fixes

Conversation

@GlobalTechInfo

@GlobalTechInfo GlobalTechInfo commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Tested locally (debug, lint, R8 release, signed APK):

  • RedTermApp: NotificationChannel only on API 26+ (was crashing at startup on Android 7.0/7.1)
  • DistroInstaller: Os.symlink (API 21+) instead of java.nio.file (API 26), guarded destroyForcibly
  • Settings label: Bash templates -> Bashrc templates
  • README/CONTRIBUTING: Gradle 8.14.5, Kotlin 2.4.10
  • CHANGELOG: [Unreleased] -> [v1.0.2] with toolchain and fixes entries

Summary by CodeRabbit

  • New Features

    • Added custom Bash template management
  • Bug Fixes

    • Fixed Android 7.x compatibility issues
    • Improved notification channel handling
  • Documentation

    • Updated build requirements documentation (Gradle 8.14.5, Kotlin 2.4.10)
  • Chores

    • Updated CI and build configuration
    • Renamed "Bash templates" setting to "Bashrc templates"

…to Bashrc templates, update docs and changelog with current toolchain
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The release changes update v1.0.2 documentation, build requirements, and the settings label. Android runtime code adds API guards, version-specific process cleanup, and Android-native symbolic-link creation for older-version compatibility.

Changes

Android compatibility

Layer / File(s) Summary
Runtime compatibility and filesystem operations
app/src/main/java/com/redtermapp/RedTermApp.kt, app/src/main/java/com/redtermapp/distro/DistroInstaller.kt
Notification-channel creation now checks API support. XZ process cleanup uses API-specific termination. Tar and BusyBox symbolic links use Os.symlink.

Release and build updates

Layer / File(s) Summary
Release notes and build requirements
CHANGELOG.md, CONTRIBUTING.md, README.md
The changelog now describes v1.0.2. Build documentation requires Gradle 8.14.5 and Kotlin 2.4.10.
Settings label update
app/src/main/res/layout/activity_settings.xml
The settings label changes from “Bash templates” to “Bashrc templates.”

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: invalid-email-address

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the Android compatibility fixes, Bashrc label rename, and documentation updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch android7-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Line 8: Update the changelog workflow so the release heading remains
consistent with contributor guidance: add a ## [Unreleased] section above ##
[v1.0.2] in CHANGELOG.md, preserving the existing v1.0.2 notes below it.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbad99fb-be40-439d-8659-8e71d787d0ec

📥 Commits

Reviewing files that changed from the base of the PR and between 2b6d9e8 and 308682e.

📒 Files selected for processing (6)
  • CHANGELOG.md
  • CONTRIBUTING.md
  • README.md
  • app/src/main/java/com/redtermapp/RedTermApp.kt
  • app/src/main/java/com/redtermapp/distro/DistroInstaller.kt
  • app/src/main/res/layout/activity_settings.xml

Comment thread CHANGELOG.md
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
## [v1.0.2]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Keep the changelog workflow consistent with the new release heading.

CHANGELOG.md now starts with ## [v1.0.2], but CONTRIBUTING.md Lines 86-91 still instruct contributors to use ## [Unreleased]. Add a new ## [Unreleased] section above v1.0.2, or update the contributor and release-workflow instructions. Otherwise, future release notes can be omitted from the tag-specific section.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CHANGELOG.md` at line 8, Update the changelog workflow so the release heading
remains consistent with contributor guidance: add a ## [Unreleased] section
above ## [v1.0.2] in CHANGELOG.md, preserving the existing v1.0.2 notes below
it.

@GlobalTechInfo
GlobalTechInfo merged commit a53b64d into main Aug 2, 2026
2 checks passed
@GlobalTechInfo
GlobalTechInfo deleted the android7-fixes branch August 2, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant