ci(powershell): add an exclude-rules input for deliberate rule violations#98
Merged
Conversation
…ions The first consumer proof caught this: podup's install.ps1 uses Write-Host on purpose (the script is piped through iex, so Write-Output would pollute the pipeline), and its old inline lint excluded PSAvoidUsingWriteHost for exactly that reason. The reusable had no way to express it, so adoption would have turned the lint red on intentional code. Empty default excludes nothing, matching the stricter shipped behaviour. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the v1.10.0 consumer proof, before the tag — which is the whole point of the ritual.
podup's
install.ps1usesWrite-Hostdeliberately: the installer is piped throughiex, soWrite-Outputwould leak into the expression pipeline. Its old inline lint excludedPSAvoidUsingWriteHostfor that reason, and the newpowershell-cireusable had no way to say it — the swap would have gone red on intentional code, and an ignored red is how gates die.New optional
exclude-rulesinput (comma-separated,-ExcludeRule), empty by default so the shipped strictness is unchanged for everyone else. podup's caller passes the one rule it means.Test plan: actionlint clean; the splatted invocation is exercised by podup's adoption PR, which is the consumer gate for the tag.