Conversation
) From the routed injection + resilience reviews (closing the route loop). - **(HIGH, SSRF / credential exfiltration) Safe redirects.** The OAuth HTTP clients followed redirects blindly: a 307/308 on the token endpoint re-POSTs `client_secret`+code+verifier to the redirect host, and GETs could be sent to `169.254.169.254` / `127.0.0.1` / RFC1918 (SSRF) or downgraded to `http`. A `CheckRedirect` now refuses cross-origin, https→http, and loopback/link-local/private hosts — on the default Exchange/JWKS/userinfo client and the Discover client. A caller-supplied `HTTPClient` owns its own policy. - **(MAJOR) JWKS burst-collapse.** The once-per-minute throttle bounded the steady-state rate but not a concurrent burst (N simultaneous unknown kids each fired a fetch). `singleflight` now collapses concurrent refreshes to one outbound JWKS GET. - **(minor) id_token cap.** `VerifyIDToken` rejects a token over 16 KiB before parsing, mirroring the jwt path. - **(docs)** `VerifyDomain` warns that a unique-domain flood is unbounded (rate-limit the registration endpoint); key-management notes the disk default is plaintext at rest (use a KMS `KeyStore` for high assurance); oauth documents the redirect policy. Tests: cross-origin/private/downgrade redirects refused, a 25-way unknown-kid burst collapses to ≤3 fetches, oversized id_token rejected. `go build`, `go vet`, `golangci-lint` (0 issues), the full suite with `-race`, and `govulncheck` (clean) all pass. Closes #186 Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
Jaro-c
enabled auto-merge
June 29, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.11.1 — oauth resilience and SSRF hardening (from the routed injection + resilience reviews). No public API changes.