Fix lint failures blocking CI on infra cleanup implementation#566
Merged
Fix lint failures blocking CI on infra cleanup implementation#566
Conversation
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
Agent-Logs-Url: https://github.com/GoCodeAlone/workflow/sessions/be13b61e-9a40-404b-87a6-4059d34d0aa7 Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement wfctl infra cleanup --tag for full-wfctl conformance
Fix lint failures blocking CI on infra cleanup implementation
May 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses CI lint failures introduced during the wfctl infra cleanup --tag work by removing unused code in tests and rewording comments that were being flagged by gocritic.
Changes:
- Refactored
infra_provider_dispatch_test.goto reuse the existingspecNameshelper instead of duplicating its logic inline. - Reworded code-like comments in
refactor_plan.goto avoid triggeringgocritic/commentedOutCode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/wfctl/infra_provider_dispatch_test.go | Reuses specNames(specs) in two seams to eliminate unused/duplicated logic in the test. |
| cmd/iac-codemod/refactor_plan.go | Rewords code-generation comments to avoid gocritic lint findings. |
Contributor
|
@copilot resolve the merge conflicts in this pull request and #566 (review) |
Agent-Logs-Url: https://github.com/GoCodeAlone/workflow/sessions/df55bdf2-745f-446e-8583-19440afd3a61 Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Contributor
Author
Merged |
Contributor
|
@copilot resolve the merge conflicts in this pull request |
Agent-Logs-Url: https://github.com/GoCodeAlone/workflow/sessions/da406332-b6db-41a6-ba77-5cd730eacd8a Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Contributor
Author
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI lint job was failing on two findings introduced alongside the
wfctl infra cleanup --tagimplementation.Fixes
cmd/wfctl/infra_provider_dispatch_test.go—specNameshelper was defined but never called; the twocomputeInfraPlanclosures duplicated its body inline. Replaced the inline loops withspecNames(specs)calls.cmd/iac-codemod/refactor_plan.go— Two// generates: <code>comments flagged bygocritic/commentedOutCodebecause they contained valid Go syntax (:=,return). Reworded to// AST output: `<code>`format.