Skip to content

Fix lint failures blocking CI on infra cleanup implementation #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
intel352 merged 5 commits into from
May 6, 2026
+2 −2
Merged

Fix lint failures blocking CI on infra cleanup implementation #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c89c9ba
Initial plan
Copilot May 6, 2026
a7bbd70
Fix lint errors: use specNames helper and reword AST-output comments
Copilot May 6, 2026
180513f
Merge origin/main; use placeholder in AST comment, drop nolint:unused
Copilot May 6, 2026
ff58fc4
Merge origin/main; keep <pkgAlias> placeholder in AST comment
Copilot May 6, 2026
c762920
Merge branch 'main' into copilot/implement-wfctl-infra-cleanup-tag
intel352 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/iac-codemod/refactor_plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,7 +1110,7 @@ func rewritePlanBody(fn *ast.FuncDecl, file *ast.File) {
ast.NewIdent(currentName),
},
}
// emits an assignment: plan, err := platform.ComputePlan(ctx, p, desired, current)
// emits an assignment: plan, err := <pkgAlias>.ComputePlan(ctx, p, desired, current)
planAssign := &ast.AssignStmt{
Lhs: []ast.Expr{ast.NewIdent("plan"), ast.NewIdent("err")},
Tok: token.DEFINE,
Expand Down
2 changes: 1 addition & 1 deletion cmd/wfctl/infra_bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ func bootstrapSecrets(ctx context.Context, provider secrets.Provider, cfg *Secre
if forceRotate[gen.Key] {
deleteKey := gen.Key
if delErr := provider.Delete(ctx, deleteKey); delErr != nil {
// Log and continue regardless of the error kind — both absent/unsupported
// Log and continue regardless of the error kind — both absent/unsupported
// secrets and unexpected errors should not block the rotation flow.
fmt.Fprintf(os.Stderr, "warn: rotate-pre-delete %s: %v (continuing)\n", deleteKey, delErr)
}
Expand Down
Loading