Migrate to Google Maps 3.0.0-beta #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-gogovapps
force-pushed
the
gm-3.0.0-beta
branch
2 times, most recently
from
bc14222 to
ed4b12f
Compare
jl-gogovapps
force-pushed
the
gm-3.0.0-beta
branch
4 times, most recently
from
f755989 to
6f0d991
Compare
jl-gogovapps
force-pushed
the
gm-3.0.0-beta
branch
from
6f0d991 to
361e98a
Compare
jl-gogovapps
force-pushed
the
gm-3.0.0-beta
branch
from
2be74d3 to
398937b
Compare
jl-gogovapps
force-pushed
the
polygon_holes
branch
2 times, most recently
from
ce752c6 to
7c0899a
Compare
jl-gogovapps
force-pushed
the
gm-3.0.0-beta
branch
2 times, most recently
from
9025db8 to
3e0f26d
Compare
jl-gogovapps
force-pushed
the
gm-3.0.0-beta
branch
from
3e0f26d to
7a79c0f
Compare
jl-gogovapps
force-pushed
the
gm-3.0.0-beta
branch
from
3650f1a to
a5c62b5
Compare
Adds a unit test and comments intended to avoid accidental breakage of the Dart repo's run of analysis against this repository. Addresses flutter#4183 (comment)
jl-gogovapps
force-pushed
the
gm-3.0.0-beta
branch
from
c452eab to
24eae82
Compare
…utter#4214) Currently has an out-of-band failure on master. Ignoring to re-open the tree.
Makes commands that use the package-looping base command track and report exclusions. This will make it much easier to debug/audit situations where tests aren't running when expected (e.g., when enabling a new type of test for a package that previously had to be explicitly excluded from that test to avoid failing for having no tests, but forgetting to remove the package from the exclusion list). Also fixes a latent issue with using different exclusion lists on different commands in a single CI task when using sharding could cause unexpected failures due to different sets of plugins being included for each step (e.g., build+drive with an exclude list on drive could potentially try to drive a plugin that hadn't been built in that shard) by sharding before filtering out excluded packages. Adds testing for sharding in general, as there was previously none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
39 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Google Maps has a bug where zooming in and out of the map creates strange fill behavior.
Related Issues
This builds off the the polygon_holes work by saneky
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?