refactor: ♻️ Added is_silent parameter to is_name_or_namespace_valid() #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is this for the dependency version issue? If so, please see:
Oh, is this for the dev tool you've been working on? |
Qubus0
reviewed
Feb 24, 2023
Collaborator
Qubus0
left a comment
Qubus0
left a comment
There was a problem hiding this comment.
good, but we need those for other validation methods as well
@ithinkandicode yeah it's for the addon, to not spam the console with each validation. Probably a good thing to have anyway though, even if it's technically not needed in the mod loader itself yet.
KANAjetzt
force-pushed
the
silent_is_name_or_namespace_valid
branch
from
e5995e6 to
3b5d46d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_silentparameter foris_name_or_namespace_valid(). Can be used to not log an error if the validation returnsfalse. Useful for example if the validation is used in a text input where the result will befalse, most of the times.