refactor: ♻️ Added is_silent parameter to validation functions #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added is_silent parameter to `is_name_or_namespace_valid()`, `is_semver_valid()`, `validate_dependencies_and_incompatibilities()`, `is_mod_id_valid()`. Can be used to not log an error if the validation returns `false`. Usefull for example if the validaiton is used in a text input where the result will be most of the times `false`. Implemented with the ModTool in mind.
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added is_silent parameter to
is_name_or_namespace_valid()is_semver_valid()validate_dependencies_and_incompatibilities()is_mod_id_valid()Can be used to not log an error if the validation returns
false. Useful for example if the validation is used in a text input where the result will be most of the timesfalse. Implemented with the ModTool in mind.*Sorry accidentally closed #128