Skip to content
This repository was archived by the owner on Dec 7, 2022. It is now read-only.

Create release directory and build task#73

Merged
ckundo merged 2 commits into
GoogleChrome:masterfrom
ckundo:create-release-directory
Dec 9, 2013
Merged

Create release directory and build task#73
ckundo merged 2 commits into
GoogleChrome:masterfrom
ckundo:create-release-directory

Conversation

@ckundo

@ckundo ckundo commented Nov 30, 2013

Copy link
Copy Markdown
Collaborator

Per discussion with @alice, this creates a dist/ file and grunt task to build generated javascript to the directory. This way application developers can point to the stable version of the generated file on github.

Run grunt build for releases only, so we don't get overwhelmed with diffs, and be sure to git tag -f stable to bump the tag to the build rev.

@ghost ghost assigned alice Nov 30, 2013
@ckundo

ckundo commented Dec 2, 2013

Copy link
Copy Markdown
Collaborator Author

@alice ptal when you get a chance

Comment thread Gruntfile.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should call this 'release'. 'build' to me suggests a normal build.

@alice

alice commented Dec 2, 2013

Copy link
Copy Markdown
Contributor

Do we want any more sophisticated release options like bumping version numbers etc?

https://github.com/geddski/grunt-release looks quite promising for doing major/minor/patch numbers all automatically, and we could create a modified version of scripts/output_wrapper.txt to include the version number in the preamble. Do you feel like having a play with any of that?

@ckundo

ckundo commented Dec 2, 2013

Copy link
Copy Markdown
Collaborator Author

Sure, I'll take a look.

On Mon, Dec 2, 2013 at 6:06 PM, Alice notifications@github.com wrote:

Do we want any more sophisticated release options like bumping version
numbers etc?

https://github.com/geddski/grunt-release looks quite promising for doing
major/minor/patch numbers all automatically, and we could create a modified
version of scripts/output_wrapper.txt to include the version number in the
preamble. Do you feel like having a play with any of that?


Reply to this email directly or view it on GitHubhttps://github.com//pull/73#issuecomment-29667828
.

@ckundo

ckundo commented Dec 7, 2013

Copy link
Copy Markdown
Collaborator Author

@alice I'm working on a grunt-release branch. In the meantime, do you want to merge this and we can iterate on it?

@alice

alice commented Dec 9, 2013

Copy link
Copy Markdown
Contributor

Oh yeah, sorry for not LGTMing earlier.

LGTM - I can merge, or you can.

ckundo added a commit that referenced this pull request Dec 9, 2013
Create release directory and build task
@ckundo ckundo merged commit df3b2fe into GoogleChrome:master Dec 9, 2013
@ckundo ckundo deleted the create-release-directory branch December 9, 2013 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants