Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

Initial commit for COOP+COEP article#2545

Merged
kaycebasques merged 21 commits intomasterfrom
coop-coep
Apr 16, 2020
Merged

Initial commit for COOP+COEP article#2545
kaycebasques merged 21 commits intomasterfrom
coop-coep

Conversation

@agektmr
Copy link
Member

@agektmr agektmr commented Apr 10, 2020

Fixes #2328

@agektmr agektmr added DO NOT MERGE Actively working on but experimental content Issues related to content blog Chrome 83 labels Apr 10, 2020
@agektmr agektmr requested a review from kaycebasques as a code owner April 10, 2020 13:05
@agektmr agektmr self-assigned this Apr 10, 2020
@googlebot googlebot added the cla: yes Contributor has signed the CLA label Apr 10, 2020
@agektmr agektmr requested a review from jpmedley April 10, 2020 13:05
@netlify
Copy link

netlify bot commented Apr 10, 2020

Deploy preview for web-dev-staging ready!

Built with commit 21dcff6

https://deploy-preview-2545--web-dev-staging.netlify.app

@kaycebasques
Copy link
Contributor

@agektmr it looks like you want @jpmedley to review this, is that correct?

@agektmr
Copy link
Member Author

agektmr commented Apr 11, 2020

Yes, @jpmedley is already reviewing the doc.

@agektmr agektmr force-pushed the coop-coep branch 2 times, most recently from 45e51b6 to effe980 Compare April 13, 2020 09:14
Copy link
Contributor

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few more typos.

@agektmr agektmr removed the DO NOT MERGE Actively working on but experimental label Apr 14, 2020
@agektmr
Copy link
Member Author

agektmr commented Apr 14, 2020

@jpmedley Resolved all issues but not sure how to dismiss "Changes requested" by you.

@jpmedley
Copy link
Contributor

I have to approve it.

@jpmedley
Copy link
Contributor

@kaycebasques These are things I should have found on the first review. Since none of these change words, would you mind merging these for me? Then we can finish this today.

@agektmr
Copy link
Member Author

agektmr commented Apr 14, 2020

@jpmedley Merged the suggested changes. One you LGTM, we should be good to go.

Copy link
Contributor

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll use the Commit Suggestion UI to commit these changes myself. I'm also going to check if the images can be optimized (to keep the repository size at a minimum). Then I'll merge.

@kaycebasques
Copy link
Contributor

Oh sorry @jpmedley & @agektmr I thought you had asked me to review the PR. I'm now seeing that Eiji had asked Joe to review it again. Well, it LGTM on my side now. I'll approve it and then one of you can merge it whenever you want.

@agektmr
Copy link
Member Author

agektmr commented Apr 15, 2020

I need @jpmedley's approval to merge this.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Contributor has not signed the CLA and removed cla: yes Contributor has signed the CLA labels Apr 15, 2020
@agektmr
Copy link
Member Author

agektmr commented Apr 15, 2020

I rebased locally, but might have messed up 🙄

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Contributor has signed the CLA and removed cla: no Contributor has not signed the CLA labels Apr 15, 2020
@agektmr
Copy link
Member Author

agektmr commented Apr 16, 2020

I heard that the content was split, where can I find the second part? Or is it the memory API article?

We'll start working on it after we post this. cc: @jpmedley when do you think you can start working on the other half?

In general, why are there so many, I think, unrelated changes/fixes in this pull request?

It's my bad. This should have been sorted already.

@natorion
Copy link

Looks good to me now. Thanks!

Copy link
Contributor

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can commit these suggestions myself. I think the new hero image needs to be optimized. I'll do that, too.

@kaycebasques kaycebasques merged commit 938a6a9 into master Apr 16, 2020
@kaycebasques kaycebasques deleted the coop-coep branch April 16, 2020 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beta related blog cla: yes Contributor has signed the CLA content Issues related to content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

content: CO[OE]P

7 participants