Add Files, Clipboard, and first Advanced Apps Patterns#7645
Conversation
✅ Deploy Preview for web-dev-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
|
Hi @devnook, In 8b7b2f7, I have now reflected your changes from #7875; and it almost works. Since the service worker lives in web.dev/src/site/content/en/patterns/advanced-apps/badges/demo.njk Lines 35 to 39 in 8b7b2f7 Any idea? Can we somehow smuggle |
I suggest you just move sw.js up a level to badges/sw.js and update the path in index.md |
beaufortfrancois
left a comment
There was a problem hiding this comment.
LGTM! You may want to edit all of date: to today.
src/site/content/en/blog/new-patterns-for-amazing-apps/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: François Beaufort <beaufort.francois@gmail.com>
rachelandrew
left a comment
There was a problem hiding this comment.
Approved with some very small styleguide nits.
src/site/content/en/patterns/advanced-apps/multiple-screens/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/patterns/files/handle-files-opened-from-the-file-explorer/index.md
Show resolved
Hide resolved
src/site/content/en/patterns/files/receive-shared-files/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/patterns/advanced-apps/audio-effects/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/patterns/advanced-apps/audio-effects/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/patterns/advanced-apps/audio-effects/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rachel Andrew <rachelandrew@google.com>
|
@devnook Could you flip the eng LGTM approval bit for |
|
Thank you all! I will merge this on Monday! Adding the |

Fixes #7439
Changes proposed in this pull request: