feat(workertypes): centralize CategorizedSummaryVisitor interface and EventSummary DTO (#2622)#2633
Open
jcscottiii wants to merge 1 commit into
Open
feat(workertypes): centralize CategorizedSummaryVisitor interface and EventSummary DTO (#2622)#2633jcscottiii wants to merge 1 commit into
jcscottiii wants to merge 1 commit into
Conversation
jcscottiii
force-pushed
the
feat/all-saved-search-categorizer-interface
branch
4 times, most recently
from
July 21, 2026 21:43
77e657e to
ee74103
Compare
… EventSummary DTO (#2622) Centralize summary highlight categorization and filtering across notification channels using a Visitor pattern. This ensures all delivery renderers (Email, Webhook, RSS) consume an identical, type-safe categorization contract via the visitor interface rather than maintaining potentially divergent filtering logic. - Introduce CategorizedSummaryVisitor interface and BaseSummaryVisitor engine in lib/workertypes to replace ad-hoc categorization logic across delivery channels. - Add EventSummary.Categorize(triggers) and EventSummary.Accept(visitor, triggers) for double-dispatch processing and error propagation. - Export Highlights, QueryErrors, and ResolvedQueryErrors fields on EventSummary, removing custom JSON marshaling boilerplate. - Add Godoc documentation explaining optional pointer semantics for SummaryHighlight.Moved and SummaryHighlight.Split fields. - Add unit tests for highlight filtering, category routing, visitor error handling, and summary serialization. CONV=f70d8c59-6f49-4a69-bb74-5643e908f5b1 TAG=agy
jcscottiii
force-pushed
the
feat/all-saved-search-categorizer-interface
branch
from
July 22, 2026 14:01
ee74103 to
ad1d254
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralizes summary highlight categorization and filtering across notification channels using a Visitor pattern to eliminate divergent logic across delivery channels.
Fixes #2622 (PR 1/5)
CONV=f70d8c59-6f49-4a69-bb74-5643e908f5b1
TAG=agy