This repository was archived by the owner on Apr 19, 2026. It is now read-only.
fix: replace type property with undefined except of replacing with empty string#49
Merged
developit merged 1 commit intoGoogleChromeLabs:masterfrom Jan 4, 2020
arturovt:fix/issue-25
Merged
fix: replace type property with undefined except of replacing with empty string#49developit merged 1 commit intoGoogleChromeLabs:masterfrom arturovt:fix/issue-25
type property with undefined except of replacing with empty string#49developit merged 1 commit intoGoogleChromeLabs:masterfrom
arturovt:fix/issue-25
Conversation
developit
approved these changes
Dec 25, 2019
developit
suggested changes
Dec 25, 2019
Contributor
developit
left a comment
There was a problem hiding this comment.
I just realized this breaks the following code:
const name = 'my-worker';
new Worker('./worker.js', {
type: "module",
name: name
});
Contributor
|
@arturovt Another option might be to replace |
type property with undefined except of replacing with empty string
Contributor
Author
|
Browser doesn't throw if P.S. also checked it in Chrome/Mozilla/Safari and it works perfectly. |
developit
approved these changes
Jan 4, 2020
Contributor
|
Brilliant @arturovt! Thank you so much for checking in other browsers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25, #39
I'm facing the same issue in the Angular application as we're using Prettier in our project that automatically adds those commas.
This is a tiny change that doesn't introduce any breaking changes. I was trying to find some documentation for Webpack's parser helpers but wasn't able to.
@developit ping.
Previously, tests were failing if I added comma at the end: