Skip to content
This repository was archived by the owner on Apr 19, 2026. It is now read-only.

Only warn about dynamic module workers#73

Merged
developit merged 2 commits intomasterfrom
reduce-warnings
Jun 23, 2020
Merged

Only warn about dynamic module workers#73
developit merged 2 commits intomasterfrom
reduce-warnings

Conversation

@developit
Copy link
Copy Markdown
Contributor

This removes the "new Worker() will only be bundled if passed a String" warning in cases where new Worker() is not called with {type:'module'}. It's possible this will result in folks not realizing their Worker is being left unbundled when type:module isn't used.

This should fix #12.

This removes the "new Worker() will only be bundled if passed a String" warning in cases where `new Worker()` is not called with `{type:'module'}`. It's possible this will result in folks not realizing their Worker is being left unbundled when type:module isn't used.
@pytkin
Copy link
Copy Markdown

pytkin commented Jun 4, 2020

@developit hi, any progress on this?

@developit developit merged commit 31519ec into master Jun 23, 2020
@developit developit deleted the reduce-warnings branch June 23, 2020 17:13
@pytkin
Copy link
Copy Markdown

pytkin commented Jun 23, 2020

@developit thank you :)

@akphi
Copy link
Copy Markdown

akphi commented Jun 24, 2020

@developit Thank you so much! Do you have a plan to release any time soon?

@crfrolik
Copy link
Copy Markdown

crfrolik commented Jul 9, 2020

Can a new release be created so we can get this fix? Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: option to exclude some files

4 participants