Skip to content

ci: create workflow for Spanner failure injection tests#3763

Merged
darshan-sj merged 5 commits into
GoogleCloudPlatform:mainfrom
darshan-sj:schedule-cdc-test
May 6, 2026
Merged

ci: create workflow for Spanner failure injection tests#3763
darshan-sj merged 5 commits into
GoogleCloudPlatform:mainfrom
darshan-sj:schedule-cdc-test

Conversation

@darshan-sj

@darshan-sj darshan-sj commented May 6, 2026

Copy link
Copy Markdown
Contributor

This PR creates Spanner failure injection tests CI/CD workflow. It includes formatting improvements for readability for the CDC correctness test files and updates the Maven profiles used for running these tests to ensure they are properly isolated and executed.

This workflow will be used for Failure injection tests scheduled runs as well as nightly CDC correctness test runs.

@darshan-sj
darshan-sj requested a review from a team as a code owner May 6, 2026 06:04
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces infrastructure to support automated failure injection testing for Spanner-related Dataflow templates. By adding a dedicated CI workflow and Maven profile, it enables rigorous testing of pipeline resilience against simulated transaction timeouts and network instability, ensuring data consistency and successful retries during adverse conditions.

Highlights

  • New CI Workflow: Added a new CI workflow command 'run-failure-injection-tests' to automate Spanner failure injection testing.
  • Maven Profile Integration: Introduced a new 'failureInjectionTest' Maven profile in pom.xml to configure surefire plugins for Fault Tolerance (FT) tests.
  • FT Test Enhancements: Updated DataStreamToSpannerCDCFT and SpannerToSrcDBMySQLCDCFT tests with detailed documentation and improved setup procedures to better simulate transaction timeouts and verify pipeline robustness.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/spanner-failure-injection-tests.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a failure injection testing framework by adding a Go-based test runner, a specific Maven profile, and improved documentation for fault tolerance tests. The reviewer identified a redundant flag call in the Go runner and recommended replacing 10-minute hardcoded sleeps in the integration tests with more efficient polling mechanisms to optimize CI execution time.

Comment thread cicd/cmd/run-failure-injection-tests/main.go
@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.16%. Comparing base (d31570b) to head (c401716).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3763      +/-   ##
============================================
+ Coverage     53.07%   53.16%   +0.08%     
- Complexity     6021     6497     +476     
============================================
  Files          1070     1075       +5     
  Lines         64941    65263     +322     
  Branches       7193     7235      +42     
============================================
+ Hits          34467    34696     +229     
- Misses        28163    28240      +77     
- Partials       2311     2327      +16     
Components Coverage Δ
spanner-templates 72.82% <ø> (-0.05%) ⬇️
spanner-import-export 68.64% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 80.94% <ø> (-0.06%) ⬇️
spanner-live-reverse-replication 77.06% <ø> (-0.15%) ⬇️
spanner-bulk-migration 91.11% <ø> (-0.04%) ⬇️
gcs-spanner-dv 85.76% <ø> (-0.07%) ⬇️
see 21 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pratickchokhani
pratickchokhani previously approved these changes May 6, 2026
Comment thread .github/workflows/spanner-failure-injection-tests.yml Outdated
VardhanThigle
VardhanThigle previously approved these changes May 6, 2026
@darshan-sj
darshan-sj dismissed stale reviews from VardhanThigle and pratickchokhani via c401716 May 6, 2026 09:02
@darshan-sj
darshan-sj merged commit b2215d1 into GoogleCloudPlatform:main May 6, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants