ci: create workflow for Spanner failure injection tests#3763
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces infrastructure to support automated failure injection testing for Spanner-related Dataflow templates. By adding a dedicated CI workflow and Maven profile, it enables rigorous testing of pipeline resilience against simulated transaction timeouts and network instability, ensuring data consistency and successful retries during adverse conditions. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request implements a failure injection testing framework by adding a Go-based test runner, a specific Maven profile, and improved documentation for fault tolerance tests. The reviewer identified a redundant flag call in the Go runner and recommended replacing 10-minute hardcoded sleeps in the integration tests with more efficient polling mechanisms to optimize CI execution time.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3763 +/- ##
============================================
+ Coverage 53.07% 53.16% +0.08%
- Complexity 6021 6497 +476
============================================
Files 1070 1075 +5
Lines 64941 65263 +322
Branches 7193 7235 +42
============================================
+ Hits 34467 34696 +229
- Misses 28163 28240 +77
- Partials 2311 2327 +16
🚀 New features to boost your workflow:
|
c401716
This PR creates Spanner failure injection tests CI/CD workflow. It includes formatting improvements for readability for the CDC correctness test files and updates the Maven profiles used for running these tests to ensure they are properly isolated and executed.
This workflow will be used for Failure injection tests scheduled runs as well as nightly CDC correctness test runs.