moment assumes PST instead of UTC. Change moment to create object assuming UTC to stay consistent with BQ. #508
Merged
danieldeleo merged 13 commits intoGoogleCloudPlatform:masterfrom Sep 25, 2025
Conversation
Collaborator
|
/gcbrun |
danieldeleo
approved these changes
Sep 25, 2025
1986a2d
into
GoogleCloudPlatform:master
85 of 87 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moment(...) is local mode. Ambiguous input (without offset) is assumed to be local time. Unambiguous input (with offset) is adjusted to local time.
moment.utc(...) is utc mode. Ambiguous input is assumed to be UTC. Unambiguous input is adjusted to UTC.
[source for above]
This PR modifies bqutil.fn.cw_parse_timestamp to use moment.utc(...) to create timestamps assuming UTC to stay consistent with BQ.
eg:
outputs:
They should be same with just difference in miliseconds.