Upgrade the logic for parsing flags and add test. - #1
Merged
Conversation
Don't require -dir unless -fuse or -instances_metadata is used, or if -instances contains a unix socket. Don't allow -instances_metadata unless running on GCE. Give a nicer error if windows users try to use -instances. Give a nicer message for systems which don't support FUSE and forgot to set -instances.
| case 3: | ||
| // User provided a host and port; use that. | ||
| ret.Network = spl[0] | ||
| ret.Address = fmt.Sprintf("%s:%s", spl[1], spl[2]) |
There was a problem hiding this comment.
Got it. It looks like this makes #2 redundant with this change, right? For maximum compatibility, would you want to do protocol:port(optional :address)? Or do you think it is more intuitive to do protocol:address:port? Thanks for adding in the option to specify what addresses to listen! Jason
Contributor
Author
There was a problem hiding this comment.
I think it's more intuitive to do network:host:port since host:port is the most common order when doing networking things.
elsbrock
referenced
this pull request
in elsbrock/cloudsql-proxy
Sep 13, 2021
Add basic health checks to proxy container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't require -dir unless -fuse or -instances_metadata is used, or if
-instances contains a unix socket.
Don't allow -instances_metadata unless running on GCE.
Give a nicer error if windows users try to use -instances.
Give a nicer message for systems which don't support FUSE and forgot to
set -instances.