Skip to content

Fix release version for 1.2.0#2027

Merged
chanseokoh merged 1 commit intomasterfrom
i2026-fix-release-ver-string
Jun 8, 2017
Merged

Fix release version for 1.2.0#2027
chanseokoh merged 1 commit intomasterfrom
i2026-fix-release-ver-string

Conversation

@chanseokoh
Copy link
Copy Markdown
Contributor

@chanseokoh chanseokoh commented Jun 8, 2017

Fixes #2026.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2027 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2027   +/-   ##
=========================================
  Coverage     66.06%   66.06%           
  Complexity     1864     1864           
=========================================
  Files           322      322           
  Lines         12534    12534           
  Branches       1137     1137           
=========================================
  Hits           8281     8281           
  Misses         3828     3828           
  Partials        425      425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9359fca...1a99a22. Read the comment docs.

@chanseokoh chanseokoh merged commit 9638a71 into master Jun 8, 2017
@chanseokoh chanseokoh changed the title Fix release version Fix release version for 1.2.0 Jun 8, 2017
@chanseokoh chanseokoh deleted the i2026-fix-release-ver-string branch June 8, 2017 19:02
@briandealwis
Copy link
Copy Markdown
Member

Hmm, the category still isn't appearing. Investigating.

@elharo
Copy link
Copy Markdown
Contributor

elharo commented Jun 9, 2017

Where/what exactly are you not seeing?

image

image

@chanseokoh
Copy link
Copy Markdown
Contributor Author

@briandealwis try re-installing. I see 1.2.0.

@briandealwis
Copy link
Copy Markdown
Member

Huh, in my local build, the category IU isn't copied across into the target repository. That is:

$ unzip -p gcp-repo/target/repository/content.jar | grep "<unit.*id='com.google.cloud.tools.eclipse.category'"

is empty unless I change the requires.1.range to a tight bound.

I don't know why it's working in the main builds.

Anyways, I have a patch that will pull the version from the pom.xml so that we don't have to modify the p2.inf for future releases.

@briandealwis
Copy link
Copy Markdown
Member

Ah, it works in the release build as release/release_after_kokoro.sh re-publishes the signed features and bundles, and then re-publishes the metadata.product (which pulls in the metadata.p2.inf).

@elharo
Copy link
Copy Markdown
Contributor

elharo commented Jun 9, 2017

So, no need to hold this release, right?

@briandealwis
Copy link
Copy Markdown
Member

Good to go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants