Skip to content

Update broken tests #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
averikitsch merged 11 commits into from
Jun 11, 2019
Merged

Update broken tests #1454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
74340fa
Add AutoValue dep and checkstyle fix
averikitsch Jun 10, 2019
bd36336
Checkstyle fix
averikitsch Jun 10, 2019
6dff1bb
Add error-prone plugin
averikitsch Jun 10, 2019
40831dd
Unused sample
averikitsch Jun 10, 2019
e76138c
Add Error-prone plugin
averikitsch Jun 10, 2019
4b34150
Update dependency
averikitsch Jun 10, 2019
c77a4c0
Merge branch 'master' into broken-tests
averikitsch Jun 10, 2019
920722e
Fix compiler version
averikitsch Jun 10, 2019
fdcb2e8
Merge branch 'broken-tests' of https://github.com/GoogleCloudPlatform…
averikitsch Jun 10, 2019
c1d2a43
rollback changes
averikitsch Jun 11, 2019
cb165e5
Merge branch 'master' into broken-tests
averikitsch Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...8/datastore-indexes-exploding/src/test/java/com/example/appengine/IndexesServletTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ public void doGet_emptyDatastore_writesNoWidgets() throws Exception {
.isEqualTo("Got 0 widgets.\n");
}

// CHECKSTYLE.OFF: VariableDeclarationUsageDistance
@SuppressWarnings("VariableDeclarationUsageDistance")
@Test
public void doGet_repeatedPropertyEntities_writesWidgets() throws Exception {
Expand Down
32 changes: 26 additions & 6 deletions appengine-java8/datastore/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<dependency>
<groupId>com.google.appengine</groupId>
<artifactId>appengine-api-1.0-sdk</artifactId>
<version>1.9.71</version>
<version>1.9.73</version>
</dependency>

<dependency>
Expand All @@ -53,10 +53,16 @@
<dependency>
<groupId>com.google.auto.value</groupId>
<artifactId>auto-value</artifactId>
<version>1.5.4</version>
<version>1.6.5</version>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>com.google.auto.value</groupId>
<artifactId>auto-value-annotations</artifactId>
<version>1.6.5</version>
</dependency>

<dependency>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId> <!-- @Nullable annotations -->
Expand Down Expand Up @@ -92,25 +98,25 @@
<dependency>
<groupId>com.google.appengine</groupId>
<artifactId>appengine-testing</artifactId>
<version>1.9.71</version>
<version>1.9.73</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.appengine</groupId>
<artifactId>appengine-api-stubs</artifactId>
<version>1.9.71</version>
<version>1.9.73</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.appengine</groupId>
<artifactId>appengine-tools-sdk</artifactId>
<version>1.9.71</version>
<version>1.9.73</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.truth</groupId>
<artifactId>truth</artifactId>
<version>0.42</version>
<version>0.44</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand All @@ -128,6 +134,20 @@
<deploy.stopPreviousVersion>true</deploy.stopPreviousVersion>
</configuration>
</plugin>

<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.0</version>
<configuration>
<annotationProcessorPaths>
<annotationProcessorPath>
<groupId>com.google.auto.value</groupId>
<artifactId>auto-value</artifactId>
<version>1.6.5</version>
</annotationProcessorPath>
</annotationProcessorPaths>
</configuration>
</plugin>
</plugins>
</build>
</project>
2 changes: 2 additions & 0 deletions appengine-java8/datastore/src/test/java/com/example/appengine/EntitiesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ public void repeatedProperties_storesList() throws Exception {
assertThat(retrievedFruits).containsExactlyElementsIn(favoriteFruit).inOrder();
}

// CHECKSTYLE.OFF: VariableDeclarationUsageDistance
@SuppressWarnings("VariableDeclarationUsageDistance")
@Test
public void embeddedEntity_fromEmbedded_embedsProperties() throws Exception {
Expand All @@ -240,6 +241,7 @@ public void embeddedEntity_fromEmbedded_embedsProperties() throws Exception {
.named("got.homeAddress")
.isEqualTo("123 Fake St, Made, UP 45678");
}
// CHECKSTYLE.ON: VariableDeclarationUsageDistance

private Key putEmployeeWithContactInfo(Entity contactInfo) {
Entity employee = new Entity("Employee");
Expand Down
17 changes: 13 additions & 4 deletions appengine/logs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,22 @@
<!-- for hot reload of the web application -->
<outputDirectory>${project.build.directory}/${project.build.finalName}/WEB-INF/classes</outputDirectory>
<plugins>
<plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<version>3.3</version>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
<source>1.7</source>
<target>1.7</target>
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne</arg>
</compilerArgs>
<annotationProcessorPaths>
<path>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>2.3.3</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
Expand Down
15 changes: 12 additions & 3 deletions appengine/mail/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,20 @@ Copyright 2016 Google Inc.
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<version>3.3</version>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
<source>1.7</source>
<target>1.7</target>
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne</arg>
</compilerArgs>
<annotationProcessorPaths>
<path>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>2.3.3</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
Expand Down
15 changes: 12 additions & 3 deletions appengine/memcache/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,19 @@ Copyright 2015 Google Inc.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.3</version>
<version>3.8.1</version>
<configuration>
<source>1.7</source>
<target>1.7</target>
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne</arg>
</compilerArgs>
<annotationProcessorPaths>
<path>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>2.3.3</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
</plugins>
Expand Down
15 changes: 12 additions & 3 deletions appengine/search/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,20 @@ Copyright 2015 Google Inc.
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<version>3.3</version>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
<source>1.7</source>
<target>1.7</target>
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne</arg>
</compilerArgs>
<annotationProcessorPaths>
<path>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>2.3.3</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<!-- Parent POM defines ${appengine.sdk.version} (updates frequently). -->
Expand Down
15 changes: 12 additions & 3 deletions appengine/users/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,20 @@ Copyright 2015 Google Inc.
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<version>3.3</version>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
<source>1.7</source>
<target>1.7</target>
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne</arg>
</compilerArgs>
<annotationProcessorPaths>
<path>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>2.3.3</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
Expand Down
13 changes: 12 additions & 1 deletion compute/mailjet/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,22 @@
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<version>3.3</version>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne</arg>
</compilerArgs>
<annotationProcessorPaths>
<path>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>2.3.3</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
</plugins>
Expand Down
80 changes: 0 additions & 80 deletions flexible/cloud-tasks/README.md
View file
Open in desktop

This file was deleted.

Loading