Add Salesforce source support to Datastream streams (google-beta)

[matanmggl]

Add Salesforce source support to Datastream streams in google-beta.

Release Note Template for Downstream PRs (will be copied)

datastream: added support for creating streams for Salesforce source in `google_datastream_stream`. (beta)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 773 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 787 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 295 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_stream (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  backfill_all {
    salesforce_excluded_objects {
      objects {
        fields {
          name = # value needed
        }
        object_name = # value needed
      }
    }
  }
  source_config {
    salesforce_source_config {
      exclude_objects {
        objects {
          fields {
            name = # value needed
          }
          object_name = # value needed
        }
      }
      include_objects {
        objects {
          fields {
            name = # value needed
          }
          object_name = # value needed
        }
      }
      polling_interval = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 773 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 787 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 295 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_stream (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  backfill_all {
    salesforce_excluded_objects {
      objects {
        fields {
          name = # value needed
        }
        object_name = # value needed
      }
    }
  }
  source_config {
    salesforce_source_config {
      exclude_objects {
        objects {
          fields {
            name = # value needed
          }
          object_name = # value needed
        }
      }
      include_objects {
        objects {
          fields {
            name = # value needed
          }
          object_name = # value needed
        }
      }
      polling_interval = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 773 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 787 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 297 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_stream (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  backfill_all {
    salesforce_excluded_objects {
      objects {
        fields {
          name = # value needed
        }
        object_name = # value needed
      }
    }
  }
  source_config {
    salesforce_source_config {
      exclude_objects {
        objects {
          fields {
            name = # value needed
          }
          object_name = # value needed
        }
      }
      include_objects {
        objects {
          fields {
            name = # value needed
          }
          object_name = # value needed
        }
      }
      polling_interval = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log

[ScottSuarez]

Hi ! thanks for the work. This looks good for the most part but could we add a test for the fields as mentioned above if possible? If not possible why not?

An update test that would be great too!

[matanmggl]

Thanks Scott! I'm not sure how to add tests without adding sensitive details because Salesforce instances cannot be created dynamically using Terraform and I'd need to include passwords in tests.
I successfully tested create and update manually with the verbose output.

[ScottSuarez]

it looks like there is a merge conflict. Could you pull the latest changes in from main?

[matanmggl]

Done. Thanks Scott.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 773 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 787 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 297 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_stream (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  backfill_all {
    salesforce_excluded_objects {
      objects {
        fields {
          name = # value needed
        }
        object_name = # value needed
      }
    }
  }
  source_config {
    salesforce_source_config {
      exclude_objects {
        objects {
          fields {
            name = # value needed
          }
          object_name = # value needed
        }
      }
      include_objects {
        objects {
          fields {
            name = # value needed
          }
          object_name = # value needed
        }
      }
      polling_interval = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 6
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log