Fixed datastream connection profile client_id field mapping

[melinath]

API field name is clientId: https://docs.cloud.google.com/datastream/docs/reference/rest/v1/projects.locations.connectionProfiles#oauth2clientcredentials

Note that this field is untested because it's difficult to test: #13434 (review) So the assertion that this PR will fix a permadiff is based on the general behavior of GCP APIs and not a specific bug report.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

datastream: fixed permadiff where `google_datastream_connection_profile.salesforce_profile.oauth2_client_credentials.client_id` is not read properly from the API

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 7 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 19
Passed tests: 9
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log

[melinath]

@modular-magician reassign-reviewer

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.