Skip to content

Remove samples and tests for BeyondCorp AppConnection and AppConnector - #18066

Merged
c2thorn merged 3 commits into
GoogleCloudPlatform:mainfrom
dmalinovsky:remove-beyondcorp-applink-samples
Aug 5, 2026
Merged

Remove samples and tests for BeyondCorp AppConnection and AppConnector#18066
c2thorn merged 3 commits into
GoogleCloudPlatform:mainfrom
dmalinovsky:remove-beyondcorp-applink-samples

Conversation

@dmalinovsky

@dmalinovsky dmalinovsky commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 24, 2026
@github-actions
github-actions Bot requested a review from rileykarson June 24, 2026 16:24
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@rileykarson

Copy link
Copy Markdown
Member

@modular-magician reassign-reviewer

@github-actions
github-actions Bot requested review from c2thorn and removed request for rileykarson June 28, 2026 23:55
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay.

removed the release note as this is not user-facing.

started the build.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 24, 2026
@dmalinovsky

Copy link
Copy Markdown
Contributor Author

@c2thorn, is it ready to be reviewed?

@github-actions
github-actions Bot requested a review from c2thorn July 28, 2026 17:36
@github-actions

Copy link
Copy Markdown

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build is failing because TGC needs to be skipped as well

tgc_tests:
  - name: TestAccBeyondCorpAppConnection_skipped
    skip: "All samples and tests were removed in standard provider."

@github-actions
github-actions Bot requested a review from c2thorn August 5, 2026 16:14
@dmalinovsky

Copy link
Copy Markdown
Contributor Author

@c2thorn, fixed.

@modular-magician

modular-magician commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 71a4957:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 10 files changed, 1570 deletions(-)
google-beta provider View Diff 10 files changed, 1570 deletions(-)
terraform-google-conversion View Diff 2 files changed, 4 insertions(+), 14 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
33 23 10 0
Affected Service Packages
  • beyondcorp

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@dmalinovsky, @c2thorn VCR tests complete for 71a4957!

@modular-magician

modular-magician commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d269e19:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 10 files changed, 1570 deletions(-)
google-beta provider View Diff 10 files changed, 1570 deletions(-)
terraform-google-conversion View Diff 2 files changed, 4 insertions(+), 14 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
33 23 10 0
Affected Service Packages
  • beyondcorp

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@dmalinovsky, @c2thorn VCR tests complete for d269e19!

@c2thorn
c2thorn added this pull request to the merge queue Aug 5, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 674d61a Aug 5, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment