Remove samples and tests for BeyondCorp AppConnection and AppConnector - #18066
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@modular-magician reassign-reviewer |
|
@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 3 weeks. Please take a look! Use the label |
c2thorn
left a comment
There was a problem hiding this comment.
Apologies for the delay.
removed the release note as this is not user-facing.
started the build.
|
@c2thorn, is it ready to be reviewed? |
|
@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label |
c2thorn
left a comment
There was a problem hiding this comment.
the build is failing because TGC needs to be skipped as well
tgc_tests:
- name: TestAccBeyondCorpAppConnection_skipped
skip: "All samples and tests were removed in standard provider."
|
@c2thorn, fixed. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 71a4957: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @dmalinovsky, @c2thorn VCR tests complete for 71a4957! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d269e19: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @dmalinovsky, @c2thorn VCR tests complete for d269e19! |
674d61a
Remove samples and tests for BeyondCorp AppConnection and AppConnector
We disabled creation of these deprecated resources, and need to remove the failing Terraform tests.
Fixes hashicorp/terraform-provider-google#27406
Fixes hashicorp/terraform-provider-google#27421
Fixes hashicorp/terraform-provider-google#27408
Fixes hashicorp/terraform-provider-google#27414
Fixes hashicorp/terraform-provider-google#27418
Fixes hashicorp/terraform-provider-google#27410
Fixes hashicorp/terraform-provider-google#27420
Fixes hashicorp/terraform-provider-google#27411
Fixes hashicorp/terraform-provider-google#27409
Fixes hashicorp/terraform-provider-google#27412
Fixes hashicorp/terraform-provider-google#27419
Fixes hashicorp/terraform-provider-google#27413
Fixes hashicorp/terraform-provider-google#27416
Fixes hashicorp/terraform-provider-google#27415