Skip to content

feat(chronicle): promote soar network resource to GA - #18177

Merged
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
epopcop:soar-network-ga
Aug 4, 2026
Merged

feat(chronicle): promote soar network resource to GA#18177
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
epopcop:soar-network-ga

Conversation

@epopcop

@epopcop epopcop commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

chronicle: `google_chronicle_soar_network` (GA)

@modular-magician

modular-magician commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6c01301:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 930 insertions(+), 4 deletions(-)
google-beta provider View Diff 2 files changed, 2 insertions(+), 7 deletions(-)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccChronicleSoarNetwork_chronicleSoarnetworkUpdateExample

Analytics

Total Tests Passed Skipped Affected
50 49 1 0
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the replaying VCR build log

@epopcop, @ankitgoyal0301 VCR tests complete for 6c01301!

@epopcop
epopcop marked this pull request as ready for review July 6, 2026 14:08
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from c2thorn July 6, 2026 14:08
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@c2thorn

c2thorn commented Jul 10, 2026

Copy link
Copy Markdown
Member

running GA TC test here

@c2thorn

c2thorn commented Jul 10, 2026

Copy link
Copy Markdown
Member

@ankitgoyal0301 please review

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA test passed

@github-actions

Copy link
Copy Markdown

@c2thorn This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

@c2thorn This PR is approved and has been waiting for merge for 2 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

@c2thorn This PR is approved and has been waiting for merge for 3 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@epopcop

epopcop commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Hey @c2thorn Could you please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants