Add support for scheduleCustomizations in the rule deployment resource. - #18364
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1da9c0c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rzalog, @ankitgoyal0301 VCR tests complete for 1da9c0c! |
|
@modular-magician rerun vcr |
|
/gcbrun |
b6d028b to
1ad0c1f
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1ad0c1f: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rzalog, @ankitgoyal0301 VCR tests complete for 1ad0c1f! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 27cf147: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rzalog, @ankitgoyal0301 VCR tests complete for 27cf147! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8c530e2: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @rzalog, @ankitgoyal0301 VCR tests complete for 8c530e2! |
8c530e2 to
1ad0c1f
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1ad0c1f: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @rzalog, @ankitgoyal0301 VCR tests complete for 1ad0c1f! |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1d876b1: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rzalog, @SirGitsalot, @ankitgoyal0301 VCR tests complete for 1d876b1! |
1d876b1 to
87ad968
Compare
87ad968 to
29f088c
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 87ad968: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @rzalog, @SirGitsalot, @ankitgoyal0301 VCR tests complete for 87ad968! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 29f088c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @rzalog, @SirGitsalot, @ankitgoyal0301 VCR tests complete for 29f088c! |
29f088c to
8bea50b
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8bea50b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @rzalog, @SirGitsalot, @ankitgoyal0301 VCR tests complete for 8bea50b! |
|
@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Add
schedule_customizationsfield toRuleDeploymentresource.This is for the customizable schedules feature, which is launching to GA soon.
There were two difficulties in updating the RuleDeployment resource.
Problem 1: Bad terraform interaction with backwards compatibility behaviors
With the release of customizable schedules we've added additional restrictions on which run frequencies are allowed for which rules. However, because of this, we run into a "permadiff" problem:
A similar problem happens with single-event rules.
We can mostly solve the problem using the diff suppression function. However, we have one edge case where the user has a LIVE (legacy run frequency) multi-event rule, and tries to update to HOURLY or DAILY. In that case, we will silently suppress the diff because of the single-event permadiff logic. There does not seem to be a good way around this because we can't figure out the parent rule resource rule_type corresponding to the rule deployment.
Added tests for this. I also tested manually since some of the logic depends on feature flags being flipped which we can't replicate in the basic terraform unit tests.
So to help with this, we noted a warning in the terraform docs to suggest people to start using the new customizable run frequencies. We will also add warnings to our normal API docs.
Problem 2: The run_frequency and schedule_customizations fields share a field mask
This is for the customizable schedules feature, which is launching to GA soon. In addition to the typical boilerplate of adding a new field, we had to add special logic to the custom_create and pre_update handlers to address two problems:
This causes two related issues:
We added special logic to the custom_create and pre_update handlers to handle this. Added test cases to catch these edge cases. There is no user-facing impact of this change, unlike for problem 1.
I also removed the logic that removes runFrequency from the updateMask. This is no longer needed because we made run frequency updates idempotent in Feb 2026.
Other changes
Release Note Template for Downstream PRs (will be copied)