appengine: fix test enum values for app_engine_bundled_services - #18441
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d4395af: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @riddhi-shivhare, @c2thorn VCR tests complete for d4395af! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e5d519c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @riddhi-shivhare, @c2thorn VCR tests complete for e5d519c! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 73e0e24: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @riddhi-shivhare, @c2thorn VCR tests complete for 73e0e24! |
|
@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
Hi @c2thorn, please review this PR whenever you have a moment. |
|
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label |
Description
This PR fixes acceptance test enum values and ensures proper state tracking for
app_engine_bundled_servicesongoogle_app_engine_standard_app_version:testAccAppEngineStandardAppVersion_bundledServicesUpdateto use fullBUNDLED_SERVICE_TYPE_...enum values (BUNDLED_SERVICE_TYPE_MAIL,BUNDLED_SERVICE_TYPE_USERS) instead of short strings, resolving schema validation errors in tests.ignore_read: trueto prevent state drift when the GCP API Gateway omitsappEngineBundledServicesin GET responses.StandardAppVersion.yamldescription.Testing
google-betaprovider and verified clean generation.