Skip to content

appengine: fix test enum values for app_engine_bundled_services - #18441

Merged
c2thorn merged 3 commits into
GoogleCloudPlatform:mainfrom
riddhi-shivhare:appengine-fix-bundled-services-tests
Aug 5, 2026
Merged

appengine: fix test enum values for app_engine_bundled_services#18441
c2thorn merged 3 commits into
GoogleCloudPlatform:mainfrom
riddhi-shivhare:appengine-fix-bundled-services-tests

Conversation

@riddhi-shivhare

@riddhi-shivhare riddhi-shivhare commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes acceptance test enum values and ensures proper state tracking for app_engine_bundled_services on google_app_engine_standard_app_version:

  1. Fix Inconsistent Enum Values in Acceptance Tests: Updates testAccAppEngineStandardAppVersion_bundledServicesUpdate to use full BUNDLED_SERVICE_TYPE_... enum values (BUNDLED_SERVICE_TYPE_MAIL, BUNDLED_SERVICE_TYPE_USERS) instead of short strings, resolving schema validation errors in tests.
  2. Ignore Read Drift: Retains ignore_read: true to prevent state drift when the GCP API Gateway omits appEngineBundledServices in GET responses.
  3. Doc Formatting: Fixed mixed quote formatting in StandardAppVersion.yaml description.

Testing

  • Built local google-beta provider and verified clean generation.
  • Validated acceptance tests with full enum strings.
appengine: fixed acceptance test enum values for `app_engine_bundled_services` in `google_app_engine_standard_app_version`

@github-actions
github-actions Bot requested a review from c2thorn July 29, 2026 04:24
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d4395af:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 13 insertions(+), 3 deletions(-)
google-beta provider View Diff 3 files changed, 13 insertions(+), 3 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
16 12 3 1
Affected Service Packages
  • appengine

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionBundledServicesExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionBundledServicesExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@riddhi-shivhare, @c2thorn VCR tests complete for d4395af!

@modular-magician

modular-magician commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e5d519c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 14 insertions(+), 4 deletions(-)
google-beta provider View Diff 4 files changed, 14 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
16 12 3 1
Affected Service Packages
  • appengine

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionBundledServicesExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionBundledServicesExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@riddhi-shivhare, @c2thorn VCR tests complete for e5d519c!

@riddhi-shivhare riddhi-shivhare changed the title appengine: remove ignore_read and fix test enum values for app_engine_bundled_services appengine: fix test enum values for app_engine_bundled_services Jul 29, 2026
@modular-magician

modular-magician commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 73e0e24:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 2 insertions(+), 2 deletions(-)
google-beta provider View Diff 2 files changed, 2 insertions(+), 2 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
16 13 3 0
Affected Service Packages
  • appengine

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@riddhi-shivhare, @c2thorn VCR tests complete for 73e0e24!

@github-actions

Copy link
Copy Markdown

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@riddhi-shivhare

Copy link
Copy Markdown
Contributor Author

Hi @c2thorn, please review this PR whenever you have a moment.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants