fix(recaptchaenterprise) Fix recaptchaenterprise action settings map canonicalization - #18443
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 075ff3e: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @Cory-Kramer, @rileykarson VCR tests complete for 075ff3e! |
| if cd != nil { | ||
| items[k] = *cd | ||
| } | ||
| items := make(map[string]KeyWebSettingsChallengeSettingsActionSettings) |
There was a problem hiding this comment.
Could you add a test to exercise the corrected behaviour?
There was a problem hiding this comment.
I've added a new unit test with the case described in the reported issue
…canonicalization Preserve live-only action-settings entries during canonicalization so updates that change action map keys are not skipped. Fix for hashicorp/terraform-provider-google#28502
075ff3e to
d1e9325
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d1e9325: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @Cory-Kramer, @rileykarson VCR tests complete for d1e9325! |
Preserve live-only action-settings entries during canonicalization so updates that change action map keys are not skipped.
Fixes hashicorp/terraform-provider-google#28502
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.