Add google_vertex_ai_evaluation_metric resource - #18458
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@navekshasood could you review this as the service team reviewer? |
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c134d96: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_evaluation_metric" "primary" {
encryption_spec {
kms_key_name = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @gregbreard, @melinath VCR tests complete for c134d96! |
|
@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label |
melinath
left a comment
There was a problem hiding this comment.
Overall this looks good - it's pretty straightforward. The one issue is that it's not covering the KMS key name in tests. Could you fix that?
Guidance for using KMS keys in tests: https://googlecloudplatform.github.io/magic-modules/test/test/#cryptokeys
melinath
left a comment
There was a problem hiding this comment.
Contributor is OOO and this is close enough. I tested locally & confirmed that the key_name field works correctly. I'll open a separate PR to add it to the test.
|
Failing VCR looks unrelated. |
590a3bd
Summary
Adds a new resource
google_vertex_ai_evaluation_metricfor managingVertex AI EvaluationMetric resources, which represent reusable metric
configurations for model evaluation (LLM-based metrics and custom code
execution metrics).
Resource details
evaluation_metric_idparameter)