Skip to content

Add google_vertex_ai_evaluation_metric resource - #18458

Merged
melinath merged 2 commits into
GoogleCloudPlatform:mainfrom
gregbreard:vertex-ai-evaluation-metric
Aug 5, 2026
Merged

Add google_vertex_ai_evaluation_metric resource#18458
melinath merged 2 commits into
GoogleCloudPlatform:mainfrom
gregbreard:vertex-ai-evaluation-metric

Conversation

@gregbreard

Copy link
Copy Markdown
Member

Summary

Adds a new resource google_vertex_ai_evaluation_metric for managing
Vertex AI EvaluationMetric resources, which represent reusable metric
configurations for model evaluation (LLM-based metrics and custom code
execution metrics).

Resource details

  • CRUD: Create, Get, List, Delete (LRO). No Update — resource is immutable.
  • Client-specified ID: Optional (evaluation_metric_id parameter)
  • Async: Delete only (LRO)
  • Fields: display_name, description, metric (JSON), labels, gcs_uri, encryption_spec
`google_vertex_ai_evaluation_metric`

@github-actions
github-actions Bot requested a review from melinath July 29, 2026 22:03
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@gregbreard

Copy link
Copy Markdown
Member Author

@navekshasood could you review this as the service team reviewer?

@modular-magician

This comment was marked as outdated.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/aiplatform-evaluation and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 31, 2026
@modular-magician

modular-magician commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c134d96:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1445 insertions(+)
google-beta provider View Diff 5 files changed, 1445 insertions(+)
terraform-google-conversion View Diff 1 file changed, 212 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_evaluation_metric (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_evaluation_metric" "primary" {
  encryption_spec {
    kms_key_name = # value needed
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
112 103 7 2
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIEvaluationMetric_vertexAiEvaluationMetricFullExample
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIEvaluationMetric_vertexAiEvaluationMetricFullExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gregbreard, @melinath VCR tests complete for c134d96!

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good - it's pretty straightforward. The one issue is that it's not covering the KMS key name in tests. Could you fix that?

Guidance for using KMS keys in tests: https://googlecloudplatform.github.io/magic-modules/test/test/#cryptokeys

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributor is OOO and this is close enough. I tested locally & confirmed that the key_name field works correctly. I'll open a separate PR to add it to the test.

@melinath

melinath commented Aug 5, 2026

Copy link
Copy Markdown
Member

Failing VCR looks unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants