Skip to content

datasource: migrate google_compute_networks compute call from Apiary … - #18511

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
jcromanu:data_source_google_compute_networks
Aug 10, 2026
Merged

datasource: migrate google_compute_networks compute call from Apiary …#18511
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
jcromanu:data_source_google_compute_networks

Conversation

@jcromanu

@jcromanu jcromanu commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

…to REST

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

datasource: migrated google_compute_networks data source to use direct HTTP rather than a client library

@jcromanu
jcromanu marked this pull request as draft August 4, 2026 00:14
@github-actions
github-actions Bot requested a review from melinath August 4, 2026 00:15
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cdb795f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 20 insertions(+), 6 deletions(-)
google-beta provider View Diff 1 file changed, 20 insertions(+), 6 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1555 1458 95 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcromanu, @melinath VCR tests complete for cdb795f!

@melinath

melinath commented Aug 4, 2026

Copy link
Copy Markdown
Member

Reached out offline; closing for now.

@melinath melinath closed this Aug 4, 2026
@rileykarson rileykarson reopened this Aug 4, 2026
@modular-magician

modular-magician commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cdb795f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 20 insertions(+), 6 deletions(-)
google-beta provider View Diff 1 file changed, 20 insertions(+), 6 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1555 1458 95 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcromanu, @melinath VCR tests complete for cdb795f!

@jcromanu
jcromanu marked this pull request as ready for review August 10, 2026 16:11

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VCR failures look unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants