Skip to content

Update Service Directory service for GitLab Enterprise test - #18524

Merged
ScottSuarez merged 1 commit into
GoogleCloudPlatform:mainfrom
shannongoad:main
Aug 5, 2026
Merged

Update Service Directory service for GitLab Enterprise test#18524
ScottSuarez merged 1 commit into
GoogleCloudPlatform:mainfrom
shannongoad:main

Conversation

@shannongoad

@shannongoad shannongoad commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Update the Service Directory service name from terraform-gitlab to terraform-gle in the TestAccDeveloperConnectAccountConnector_GlePrivAccountConnector test configuration.

The service terraform-gitlab does not exist in the test project devconnect-terraform-creds, causing the nightly acceptance tests to fail with a 100% rate. The correct service name is terraform-gle which is configured and active in the test project.

Fixes: hashicorp/terraform-provider-google#28635

None

…unt_connector_test.go

To fix a failing terraform test
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from ScottSuarez August 4, 2026 17:32
@modular-magician modular-magician added service/developerconnect and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 5, 2026
@modular-magician

modular-magician commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5f6127a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 1 insertion(+), 1 deletion(-)
google-beta provider View Diff 1 file changed, 1 insertion(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
37 33 3 1
Affected Service Packages
  • developerconnect

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDeveloperConnectAccountConnector_GlePrivAccountConnector

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDeveloperConnectAccountConnector_GlePrivAccountConnector

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@shannongoad VCR tests complete for 5f6127a!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccDeveloperConnectAccountConnector_GlePrivAccountConnector

3 participants