Update IAM test imports to use Sample configuration - #18537
Merged
Conversation
IAM test config is based on the first test listed in the resource's .yaml config. This is usually the basic no frills example, which turns out to have worked out for every IAM test generated from the template so far. As part of my IAM skill work I happened to target a resource (Eventarc Channel) where this wasn't the case - the first test there bootstraps a KMS key, which in turn requires a `resourcemanager` import, which didn't get imported.
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bcc5963: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
SirGitsalot
marked this pull request as ready for review
August 5, 2026 18:54
melinath
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IAM test config is based on the first test listed in the resource's .yaml config. This is usually the basic no frills example, which turns out to have worked out for every IAM test generated from the template so far. As part of my IAM skill work I happened to target a resource (Eventarc Channel) where this wasn't the case - the first test there bootstraps a KMS key, which in turn requires a
resourcemanagerimport, which didn't get imported.