Added add_fields workflow - #18548
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 989fab9: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
c2thorn
left a comment
c2thorn
left a comment
There was a problem hiding this comment.
Looks great. Approving now for whenever GHA comes back online.
|
|
||
| Add the requested field(s) to the requested resource(s). | ||
|
|
||
| ### 3. Add tests for the fields |
There was a problem hiding this comment.
Very strong, I like this section a lot. New resource should probably route to this instead of default-workflow https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.agents/skills/workflows/new_resource/SKILL.md#2b-manual-path
Outside of this PR's scope, just noting.
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 989fab9: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 989fab9: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3e746b8: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
67c69ea
4 participants
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.