Skip to content

observability: add google_observability_link resource - #18803

Merged
ScottSuarez merged 1 commit into
GoogleCloudPlatform:mainfrom
ScottSuarez:add_observability_link_resource
Sep 1, 2026
Merged

observability: add google_observability_link resource#18803
ScottSuarez merged 1 commit into
GoogleCloudPlatform:mainfrom
ScottSuarez:add_observability_link_resource

Conversation

@ScottSuarez

Copy link
Copy Markdown
Contributor

Adds Terraform support for the google_observability_link resource to expose observability dataset data (e.g. BigQuery linked datasets).

`google_observability_link`

@modular-magician

modular-magician commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 369df88:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1053 insertions(+)
google-beta provider View Diff 4 files changed, 1053 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 116 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
19 18 0 1
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccObservabilityLink_observabilityLinkBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccObservabilityLink_observabilityLinkBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ScottSuarez VCR tests complete for 369df88!

@ScottSuarez
ScottSuarez force-pushed the add_observability_link_resource branch from 369df88 to 83cb39f Compare August 27, 2026 20:13
@modular-magician

modular-magician commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 83cb39f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1075 insertions(+)
google-beta provider View Diff 4 files changed, 1075 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 130 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
19 18 0 1
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccObservabilityLink_observabilityLinkBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccObservabilityLink_observabilityLinkBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ScottSuarez VCR tests complete for 83cb39f!

@ScottSuarez
ScottSuarez force-pushed the add_observability_link_resource branch from 83cb39f to 5f24d33 Compare August 27, 2026 20:50
@modular-magician

modular-magician commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5f24d33:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1108 insertions(+)
google-beta provider View Diff 4 files changed, 1108 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 145 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
19 18 0 1
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccObservabilityLink_observabilityLinkBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccObservabilityLink_observabilityLinkBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ScottSuarez VCR tests complete for 5f24d33!

@ScottSuarez
ScottSuarez force-pushed the add_observability_link_resource branch from 5f24d33 to f735f49 Compare August 27, 2026 21:19
@modular-magician

modular-magician commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f735f49:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1159 insertions(+)
google-beta provider View Diff 4 files changed, 1159 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
19 18 0 1
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccObservabilityLink_observabilityLinkBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccObservabilityLink_observabilityLinkBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ScottSuarez VCR tests complete for f735f49!

@ScottSuarez
ScottSuarez force-pushed the add_observability_link_resource branch from f735f49 to 5492949 Compare August 27, 2026 21:43
@modular-magician

modular-magician commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5492949:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1104 insertions(+)
google-beta provider View Diff 4 files changed, 1104 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 143 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
19 18 0 1
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccObservabilityLink_observabilityLinkBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccObservabilityLink_observabilityLinkBasicExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@ScottSuarez VCR tests complete for 5492949!

@ScottSuarez

Copy link
Copy Markdown
Contributor Author

@modular-magician assign-reviewer @slevenick

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from slevenick August 27, 2026 23:09
Comment thread mmv1/products/observability/Link.yaml Outdated
- name: displayName
type: String
description: User friendly display name.
default_from_api: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not set these in a test and confirm they get set by the API? It's unusual to have these as default_from_api but it could be 🤷

@ScottSuarez
ScottSuarez force-pushed the add_observability_link_resource branch from 5492949 to e36734f Compare September 1, 2026 16:28
@modular-magician

modular-magician commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e36734f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1102 insertions(+)
google-beta provider View Diff 4 files changed, 1102 insertions(+)
terraform-google-conversion View Diff 1 file changed, 135 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 143 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
19 19 0 0
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@ScottSuarez VCR tests complete for e36734f!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants