observability: add google_observability_link resource - #18803
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 369df88: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @ScottSuarez VCR tests complete for 369df88! |
369df88 to
83cb39f
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 83cb39f: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @ScottSuarez VCR tests complete for 83cb39f! |
83cb39f to
5f24d33
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5f24d33: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @ScottSuarez VCR tests complete for 5f24d33! |
5f24d33 to
f735f49
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f735f49: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @ScottSuarez VCR tests complete for f735f49! |
f735f49 to
5492949
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5492949: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @ScottSuarez VCR tests complete for 5492949! |
|
@modular-magician assign-reviewer @slevenick |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
| - name: displayName | ||
| type: String | ||
| description: User friendly display name. | ||
| default_from_api: true |
There was a problem hiding this comment.
Can you not set these in a test and confirm they get set by the API? It's unusual to have these as default_from_api but it could be 🤷
5492949 to
e36734f
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e36734f: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @ScottSuarez VCR tests complete for e36734f! |
Adds Terraform support for the
google_observability_linkresource to expose observability dataset data (e.g. BigQuery linked datasets).