Skip to content

send disable_auto_scheduling#6946

Closed
edwardmedia wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
edwardmedia:issue13221
Closed

send disable_auto_scheduling#6946
edwardmedia wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
edwardmedia:issue13221

Conversation

@edwardmedia

@edwardmedia edwardmedia commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Fixes hashicorp/terraform-provider-google#13221

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquerydatatransfer: fixed a bug when updating`schedule_options.disable_auto_scheduling` with false on `google_bigquery_data_transfer_config`

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 6 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 1 file changed, 6 insertions(+), 5 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

sensitive: true
# api does not send schedule_options.disable_auto_scheduling back when it is set to false b/262259565
scheduleOptions: !ruby/object:Overrides::Terraform::PropertyOverride
diff_suppress_func: 'emptyOrUnsetBlockDiffSuppress'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be handle by setting optional + compute

@edwardmedia edwardmedia Dec 12, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. In this case, api sends empty. Can Computed work for thing like that? @shuyama1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: a custom diff suppress func will be added to replace emptyOrUnsetBlockDiffSuppress as this should be an easy logic and plus, we recommend against using emptyOrUnsetBlockDiffSuppress.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuyama1 does the new function available or can we merge this PR with emptyOrUnsetBlockDiffSuppress ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwardmedia gentle ping. Any update on this?

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2340
Passed tests 2090
Skipped tests: 244
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccDataSourceSqlDatabaseInstance_basic|TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccSqlUser_postgresAbandon|TestAccSqlUser_postgres|TestAccSqlUser_postgresIAM

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests passed during RECORDING mode:
TestAccDataSourceSqlDatabaseInstance_basic[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccSqlUser_postgresAbandon[Debug log]
TestAccSqlUser_postgres[Debug log]
TestAccSqlUser_postgresIAM[Debug log]

All tests passed
View the build log or the debug log for each test

@nicolas-carlier-ls

nicolas-carlier-ls commented Sep 13, 2023

Copy link
Copy Markdown

The issue still exists @edwardmedia Can you reopen the PR the work was done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting BQ data transfer config disableAutoScheduling to false produces empty scheduleOptions

4 participants