send disable_auto_scheduling#6946
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 6 insertions(+), 5 deletions(-)) |
| sensitive: true | ||
| # api does not send schedule_options.disable_auto_scheduling back when it is set to false b/262259565 | ||
| scheduleOptions: !ruby/object:Overrides::Terraform::PropertyOverride | ||
| diff_suppress_func: 'emptyOrUnsetBlockDiffSuppress' |
There was a problem hiding this comment.
Can this be handle by setting optional + compute
There was a problem hiding this comment.
I don't think so. In this case, api sends empty. Can Computed work for thing like that? @shuyama1
There was a problem hiding this comment.
Update: a custom diff suppress func will be added to replace emptyOrUnsetBlockDiffSuppress as this should be an easy logic and plus, we recommend against using emptyOrUnsetBlockDiffSuppress.
There was a problem hiding this comment.
@shuyama1 does the new function available or can we merge this PR with emptyOrUnsetBlockDiffSuppress ?
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccDataSourceSqlDatabaseInstance_basic|TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccSqlUser_postgresAbandon|TestAccSqlUser_postgres|TestAccSqlUser_postgresIAM |
|
Tests passed during RECORDING mode: All tests passed |
|
The issue still exists @edwardmedia Can you reopen the PR the work was done |
Fixes hashicorp/terraform-provider-google#13221
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)