Skip to content

Ignore blank fields in analytics view, more comments, and widget edit#1221

Merged
pintofloyed merged 3 commits into
GoogleCloudPlatform:masterfrom
jkru3:dashboard-fixes-1
Apr 13, 2026
Merged

Ignore blank fields in analytics view, more comments, and widget edit#1221
pintofloyed merged 3 commits into
GoogleCloudPlatform:masterfrom
jkru3:dashboard-fixes-1

Conversation

@jkru3

@jkru3 jkru3 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Update analytics view SQL and dashboard widgets

Description:
This CL updates the SQL logic for the GKE Maintenance Analytics view and makes improvements to the GKE Maintenance Dashboard widgets.

Analytics View SQL (README.md) Updates:

  • Improved Robustness for Missing Values: Chained NULLIF(..., '') across JSON payload extractions to safely handle empty annotation strings and catch Go's zero-time formatting ('0001-01-01T00:00:00Z').
  • Enhanced State Ranking: Introduced a status_rank column and refined CASE statements to precisely determine the cycle's final aggregated state (e.g. prioritizing COMPLETE, DELETED, ONGOING, PENDING, and ignoring UNKNOWN cases).
  • Comment Organization: Expanded the analytical SQL's inline comments, breaking the logic out into clear, labeled stages (e.g., 1. EXTRACT RAW LOGS, 2. PRE-PARSE LOGS) to outline the state machine visually.

Dashboard Widgets & Layout (gke-maintenance-dashboard.json) Updates:

  • P95 Threshold Refinements: Changed the "Avg days" and "P95 hours maintenance downtime" widget to properly calculate thresholds in hours (dividing by 3600).

@jkru3
jkru3 marked this pull request as ready for review March 4, 2026 03:39
Comment thread dashboards/google-kubernetes-engine-ai/gke-maintenance-dashboard.json Outdated
Comment thread dashboards/google-kubernetes-engine-ai/gke-maintenance-dashboard.json Outdated

@jkru3 jkru3 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches Floyed, Thank you :)

@pintofloyed
pintofloyed merged commit 0ad8dc7 into GoogleCloudPlatform:master Apr 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants